fix: add creationflags to plugins subprocess calls (Windows console flash) - #76279
Closed
JonthanaHanh wants to merge 1 commit into
Closed
fix: add creationflags to plugins subprocess calls (Windows console flash)#76279JonthanaHanh wants to merge 1 commit into
JonthanaHanh wants to merge 1 commit into
Conversation
…lash) Three plugin adapters have non-interactive subprocess calls (ffprobe, ffmpeg, ImageMagick convert) missing CREATE_NO_WINDOW on Windows: - plugins/platforms/matrix/adapter.py — ffprobe duration + ffmpeg PCM extraction + ffmpeg Ogg/Opus transcode (3 calls) - plugins/platforms/discord/adapter.py — ffprobe duration probe (1 call) - plugins/platforms/simplex/adapter.py — ImageMagick convert for format conversion + thumbnail generation (2 calls) Without CREATE_NO_WINDOW (0x08000000), each subprocess spawns a visible console window (cmd.exe / conhost.exe) that flashes on Windows. Uses the existing windows_hide_flags() helper from hermes_cli._subprocess_compat (local imports, same pattern as PR NousResearch#65660).
Contributor
|
Thanks for tracing the remaining plugin subprocesses. This is an automated hermes-sweeper review: the console-flash guarantee is already implemented on current
Closing as already implemented on main; thank you for the Windows coverage. |
teknium1
added
the
sweeper:implemented-on-main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three plugin adapters have non-interactive subprocess calls (ffprobe, ffmpeg, ImageMagick convert) missing CREATE_NO_WINDOW on Windows. Without it, each subprocess spawns a visible console window that flashes.
Changes
Fix
Import windows_hide_flags() from hermes_cli._subprocess_compat (local import, same pattern as #65660) and pass creationflags=windows_hide_flags() to each subprocess.run() call. The helper returns 0x08000000 (CREATE_NO_WINDOW) on Windows and 0 elsewhere.
Related