fix(whatsapp): preserve stanza-only quote context - #76075
Conversation
cfc4444 to
d6653e5
Compare
|
Rebased without conflicts onto current main |
Related: #73399 addresses durable platform-metadata persistence; this PR fixes the earlier WhatsApp bridge-to-adapter-to-queued-turn reply-context path. |
|
Thanks for narrowing this to the live WhatsApp bridge-to-adapter path. Current The change in Automated hermes-sweeper review. |
SummaryOne PR addresses #74380. #76075 fixes the live WhatsApp bridge-to-adapter-to-queued-turn loss of stanza-ID-only reply context, while durable canonical platform-metadata persistence remains assigned to #73399. Related pull requests
Suggested consolidationKeep #76075 open with a salvage path: retain its bridge extraction, adapter mapping, WhatsApp message-ID fallback, and targeted regression tests as the focused live-path fix, while leaving durable platform-metadata persistence to #73399. There are no competing PRs or duplicates to close. Complex graphflowchart LR
classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
classDef best stroke-width:3px,stroke:#b45309
classDef target stroke-width:3px,stroke:#4338ca
I74380(["issue #74380 (open)"])
P76075["PR #76075 (open)"]
P76075 -->|best fix| I74380
class I74380 open
class P76075 open
class P76075 best
class P76075 target
click I74380 "https://github.com/NousResearch/hermes-agent/issues/74380"
click P76075 "https://github.com/NousResearch/hermes-agent/pull/76075"
Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label). Cross-PR triage: Reviewed 1 pull request and 1 issue in this complex. Each diff was read against this issue; Assessment working set: 9 kB of PR diffs, 7 kB of issue/PR text, <1 kB of discussion (3 comments), 2 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch. |
Closes #74380
Summary
stanzaIdas authoritative reply metadata even when the inlinequotedMessagepayload is absentScope
PR #73399 owns durable
platform_metadatapersistence. This PR deliberately does not duplicate that schema work; it fixes the earlier live bridge -> adapter -> queued-turn rendering path.Verification
node --checkfor both changed bridge modulesnode scripts/whatsapp-bridge/bridge.native.test.mjsscripts/run_tests.sh tests/gateway/test_whatsapp_formatting.py tests/gateway/test_reply_to_injection.py tests/gateway/test_queue_command.py tests/gateway/test_whatsapp_native_delivery.py -q(18 passed)