fix(desktop): put Toggle terminal on the ⌘K on/off pattern - #75862
Merged
Conversation
The terminal row still lived under Go to as a one-way open. It never showed live state and couldn't hide. Move it through paletteToggle next to logs, yolo, status bar, and layout edit so every binary ⌘K toggle shares the same underlined on/off note.
Contributor
૮ >ﻌ< ა ci reviewran on 3572424 ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job2 visual diffs. inline evidence upload failed. Failed to upload diff-1508682a2ae8-boot-ready-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-1508682a2ae8-boot-ready-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso) |
OutThisLife
added a commit
that referenced
this pull request
Aug 1, 2026
main reworked the same surface while this was open, so three hunks needed deciding rather than accepting. Logs became summon-only (#75862): the contribution only exists while $logsOpen is on, docked as its OWN zone beside the terminal instead of a tab in its strip. That supersedes the static logs pane and the bindToolPaneCollapse call here — main already registers logs' closer/opener directly, so both were dropped in favour of its version. main also added a ⌘K "Toggle terminal" row reading $terminalTakeover, and gave logs back a 7.5rem minHeight under a comment claiming the terminal's sizing rule. Both are the bugs this branch fixes, so they move onto the shared behaviour: the palette row reads isPaneVisible/togglePaneVisible like every other pane toggle, and logs loses the floor so the comment is true — the sash folds its zone to the rail instead of stranding a sliver.
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
fix(desktop): put Toggle terminal on the ⌘K on/off pattern
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
main reworked the same surface while this was open, so three hunks needed deciding rather than accepting. Logs became summon-only (NousResearch#75862): the contribution only exists while $logsOpen is on, docked as its OWN zone beside the terminal instead of a tab in its strip. That supersedes the static logs pane and the bindToolPaneCollapse call here — main already registers logs' closer/opener directly, so both were dropped in favour of its version. main also added a ⌘K "Toggle terminal" row reading $terminalTakeover, and gave logs back a 7.5rem minHeight under a comment claiming the terminal's sizing rule. Both are the bugs this branch fixes, so they move onto the shared behaviour: the palette row reads isPaneVisible/togglePaneVisible like every other pane toggle, and logs loses the floor so the comment is true — the sash folds its zone to the rail instead of stranding a sliver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paletteTogglenext to logs, yolo, status bar, and layout edit so every binary palette toggle shows the underlined on/off note, flips both ways, and keeps the palette open.Test plan
terminal→ row reads Toggle terminal with underlinedon/off