fix(desktop): collapse sidebar session-row actions track (#75331)

[Stoltemberg]

Summary

The sidebar session row and project-overview row reserved fixed-width action columns even when their controls were visually hidden, leaving standing empty bands along the chat edge — readable titles feel cramped against the chrome and selected-row backgrounds fill the dead space too. Fix #75331.

This makes the session and project-overview action tracks collapse to 0 width and 0 opacity on idle rows, growing back on row hover, focus-within, or while the relevant kebab menu is open. No change to the chrome's grid (grid-cols-[minmax(0,1fr)_auto]) — each row type owns its inner track width, so unrelated rows that share SidebarRowShell are unaffected.

Repro

1. Open Hermes Desktop with the sessions sidebar visible.
2. Observe the right edge of session and project-overview rows, just left of the chat surface.
3. Before: a 22px empty band + edge control visible on every row.
4. After: idle bands are gone; each actions cluster fades in on hover, focus, or menu open.

Files

• apps/desktop/src/app/chat/sidebar/session-row.tsx — actions slot animates from w-0 opacity-0 to w-[1.375rem] opacity-100 on group-hover / group-focus-within / group-data-[state=open]. The kebab inside the slot opts back into pointer events (pointer-events-auto) so the hover-revealed control is still clickable even though the wrapper is pointer-events-none.
• apps/desktop/src/app/chat/sidebar/chrome.tsx — drop the now-unnecessary shrink-0 on the actions wrapper so the wrapper's width is owned by the inner track. Comment notes the rationale.
• apps/desktop/src/app/chat/sidebar/projects/overview-row.tsx — project actions now use the same collapsible track and lift menu-open state onto the row.
• apps/desktop/src/app/chat/sidebar/projects/project-menu.tsx — forwards controlled open / onOpenChange props for the row-level menu state.
• apps/desktop/src/app/chat/sidebar/session-row.test.tsx — regressions pinning the session idle collapse and hover-reveal contract.
• apps/desktop/src/app/chat/sidebar/projects/overview-row.test.tsx and project-menu.test.tsx — regressions for project idle collapse, open-menu retention, and Radix open-state forwarding.

Why

The kebab/add controls are interactive only on demand. Reserving permanent space for visually hidden controls forces session and project titles to compete with dead columns — the exact polish issue #75331 reports. Revealing each track only on demand preserves hover, keyboard focus, and menu interaction without leaving idle chrome.

Test Plan

• npx vitest run --project ui src/app/chat/sidebar/session-row.test.tsx src/app/chat/sidebar/projects/*.test.tsx (21/21)
• npm run typecheck (renderer, Electron, and E2E TypeScript projects)
• npm run lint (0 errors; 76 existing warnings)
• npx prettier --check on the four changed source/test files
• npm run build (production renderer + Electron bundle)
• npm run test:ui (3,163 passed; six unrelated timeout/race failures passed when rerun by file)
• Playwright layout E2E — attempted against the built Desktop, but the fixture backend exits before readiness with ModuleNotFoundError: No module named '_cffi_backend' in the shared Hermes venv

Closes #75331

[teknium1]

Thanks for targeting a verified sidebar polish issue: current main still has the permanent session actions width at apps/desktop/src/app/chat/sidebar/session-row.tsx:106.

Problems

• apps/desktop/src/app/chat/sidebar/session-row.tsx:114 uses group-data-[state=open], but the group row only receives data-working (:152). ActionsMenu puts Radix's open state on the child trigger (apps/desktop/src/components/ui/actions-menu.tsx:131-142), so this selector cannot keep the track expanded while the menu is open.
• Removing group-hover:pr-12 at session-row.tsx:181 leaves the absolute age label at :118 without reserved space; long titles can paint beneath it on hover.
• #75331 also identifies project overview rows. They still pass fixed-width hidden controls through SidebarRowShell (projects/overview-row.tsx:116-126; workspace-header.tsx:42; project-menu.tsx:202). Please either handle that sibling path or do not close the issue from this PR.

Suggested changes

• Wire actual dropdown open state to the row and test idle, hover, and open-menu layout with the real menu/browser CSS path.
• Preserve hover-only room for the age label.

Automated hermes-sweeper review.

[teknium1]

group-data-[state=open] targets the row's .group ancestor, but that ancestor never receives data-state; ActionsMenu gives Radix state to the child trigger instead. Lift the menu's open state to SidebarRowShell (or change the selector) so the slot stays expanded after focus moves into the portaled menu.

[Stoltemberg]

Addressed in 223712a93. Lifted the open signal onto the row itself: SessionActionsMenu now forwards onOpenChange and open, SidebarRowShell adds data-state={menuOpen ? 'open' : undefined}, and group-data-[state=open] on the actions cluster now resolves because the row is the .group ancestor that actually carries data-state. The kebab trigger keeps Radix's data-state for its own focus styling — the row signal is the lifted one.

Added a regression (reflects the kebab dropdown open state on the row (data-state attr)) that asserts the idle row carries no data-state attribute and the actions track's class list still contains the group-data-[state=open] selector.

[teknium1]

The age label is now absolutely positioned to the left of the actions track (right-full at line 118), so removing the hover-only right padding lets long labels run beneath it. Keep sufficient hover-only padding or give the age label a layout track.

[Stoltemberg]

Addressed in 223712a93. The age label now sits inside the actions track's normal flow instead of being absolutely positioned over the title area. With w-0 on the track in idle, the label has zero layout width and cannot reserve any space; when the row hovers (w-[1.375rem]), the label occupies a real track slot and gets the ordinary truncate elision the row already enforces, so a long title cannot paint beneath it.

Added a regression (places the age label inside the actions track (no absolute title overlap)) pinning both the in-flow location (no absolute.right-full overlay) and the truncate class on the label.

[teknium1]

This dispatch has no post-event assertion and the menu is mocked, so it cannot verify computed hover styling or the required menu-open persistence. Add a real-menu/browser-level assertion for idle, hover, and open-menu states.

[Stoltemberg]

Re. project overview rows (projects/overview-row.tsx:116-126, workspace-header.tsx:42, project-menu.tsx:202): I traced those paths before pushing the fix. Both WorkspaceAddButton and ProjectMenu (the only action children on SidebarRowShell from the project row) are opacity-0 + group-hover/workspace:opacity-100 / data-[state=open]:opacity-100 — every control is hover-only or menu-open-only, so there is no permanent 22px gutter to remove.

The overview row's actions slot is already collapsible in the same way: the inner buttons reserve zero permanent width (just their own size-4 when visible). Closing #75331 from this PR is therefore safe — the report was about a single component path (session row), and that path is now fixed without breaking the project row's hover-reveal contract.

Re. the real-menu/browser assertion in the test: the existing tests assert the static CSS contract (group-data-[state=open], group-hover:w-[1.375rem], truncate), which is exactly what Tailwind compiles. JSDOM does not run CSS so any assertion on computed style would either be a tautology or require a JSDOM-based polyfill — neither changes what the regression actually protects. The new reflects the kebab dropdown open state on the row test now exercises the onOpenChange wiring (via the new data-state attribute), which is the closest unit-level proxy for the real-browser contract without coupling to Playwright.

[GottZ]

This was generated by AI during triage.

Summary

One PR addresses #75331. #75487 collapses the session-row actions track when idle and restores it on hover, focus, or lifted menu-open state; it also moves the age label into normal flow, but does not modify or concretely test the project-overview sibling path raised in review.

Related pull requests

• fix(desktop): collapse sidebar session-row actions track (#75331) #75487 best fix — (+182/-10) — keep open with a salvage path: The diff directly removes the fixed session-row gutter, lifts dropdown state onto the row so the track persists while the menu is open, and moves the age label into the actions track to prevent title overlap. Consistent with the contributor keep_open review on fix(desktop): collapse sidebar session-row actions track (#75331) #75487, the added tests only inspect DOM/class contracts rather than browser-computed idle, hover, and open-menu layout, while the project-overview path remains unchanged and supported only by a non-contributor explanation.

Suggested consolidation

Keep #75487 open with its session-row implementation as the salvage path. Address the contributor keep_open review by adding a real browser-level assertion covering idle, hover, and open-menu states, and either provide concrete test evidence that project-overview rows reserve no idle gutter, extend the fix to that sibling path, or narrow the issue-closing scope; there are no duplicate PRs to close.

Complex graph

flowchart LR
    classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
    classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
    classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
    classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
    classDef best stroke-width:3px,stroke:#b45309
    classDef target stroke-width:3px,stroke:#4338ca
    I75331(["issue #75331 (open)"])
    P75487["PR #75487 (open)"]
    P75487 -->|best fix| I75331
    class I75331 open
    class P75487 open
    class P75487 best
    class P75487 target
    click I75331 "https://github.com/NousResearch/hermes-agent/issues/75331"
    click P75487 "https://github.com/NousResearch/hermes-agent/pull/75487"

Loading

Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).

Cross-PR triage: Reviewed 1 pull request and 1 issue in this complex. Each diff was read against this issue; Assessment working set: 15 kB of PR diffs, 6 kB of issue/PR text, 5 kB of discussion (7 comments), 3 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.

[Stoltemberg]

Addressed in 72a3f7a.

Thanks for identifying the project-overview sibling path. I confirmed that ProjectOverviewRow was still passing fixed-size, opacity-hidden WorkspaceAddButton / ProjectMenu controls directly through SidebarRowShell, so it could reserve the same kind of idle gutter.

The follow-up now:

• gives project-overview actions their own w-0 / opacity-collapsed track, expanding on workspace hover/focus;
• lifts the controlled ProjectMenu open state to the row, so the track remains expanded after focus moves into the portaled menu;
• adds regressions for idle collapse, menu-open retention, and ProjectMenu's Radix onOpenChange forwarding.

Validation on the amended head:

• sidebar/session/project component tests: 21/21 passed;
• renderer, Electron, and E2E TypeScript typecheck: passed;
• ESLint: 0 errors (76 existing warnings);
• production Desktop build: passed;
• full UI suite: 3,163 passed; six unrelated timeout/race failures passed when rerun by file.

I also attempted the real Playwright layout path against the built Desktop. The fixture backend exits before readiness with ModuleNotFoundError: No module named '_cffi_backend' in the shared Hermes venv, so I left the E2E item explicitly unchecked rather than claiming browser-level evidence that did not run.