fix(desktop): open safe local and Obsidian response links - #75457
Draft
nullbiscuits wants to merge 2 commits into
Draft
fix(desktop): open safe local and Obsidian response links#75457nullbiscuits wants to merge 2 commits into
nullbiscuits wants to merge 2 commits into
Conversation
teknium1
reviewed
Jul 31, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for isolating the response-link IPC capability and keeping the main-process policy fail-closed. The Obsidian part addresses a current-main gap: apps/desktop/electron/main.ts:1321-1323 only permits http:, https:, and mailto: after the file: branch.
Problems
apps/desktop/src/components/assistant-ui/markdown-text.tsx:632passesremarkPlugins={[remarkDesktopLinks]}. Streamdown treats a suppliedremarkPluginsvalue as the complete plugin list, so this replaces its default remark plugins rather than extending them. That regresses default GFM parsing for every Desktop markdown response.
Suggested changes
- Extend Streamdown's exported
defaultRemarkPluginswithremarkDesktopLinks, rather than supplying only the new plugin, and add a regression test for an existing GFM construct alongside the local-link tests.
This is an automated hermes-sweeper review.
| @@ -612,6 +632,7 @@ function MarkdownTextSurface({ | |||
| parseMarkdownIntoBlocksFn={parseMarkdownIntoBlocksCached} | |||
Contributor
There was a problem hiding this comment.
This custom list replaces Streamdown's default remarkPlugins; it does not append to them. Please extend defaultRemarkPlugins with remarkDesktopLinks so existing GFM parsing remains enabled for every Desktop response.
4 tasks
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
obsidian://openlinks in assistant response Markdownrundll32.exedirectlySecurity boundaries
file:URLsopenactionVerification
npm run check:lint— passed (0 errors; existing warnings only)git diff --check origin/main..HEAD— passednpm run build— passedThe broader UI run passed 3,164/3,172 tests. Six transient failures passed in isolation; the remaining two Billing failures were reproduced unchanged on a pristine
origin/mainbaseline and are unrelated to this patch.