fix(config): bridge reply_in_thread from platform config to extra dict - #7534
Closed
konsisumer wants to merge 2 commits into
Closed
fix(config): bridge reply_in_thread from platform config to extra dict#7534konsisumer wants to merge 2 commits into
konsisumer wants to merge 2 commits into
Conversation
konsisumer
force-pushed
the
fix/slack-reply-in-thread-bridge
branch
from
April 11, 2026 04:36
f0abeeb to
3bea279
Compare
Contributor
Author
|
Rebased onto latest
All cherry-picked from passing PR branches — these are the same fixes applied across #7153, #7226, #7265, #7305, #7398, #7513. |
Contributor
Author
|
Fixed the 3 pre-existing CI test failures (none introduced by this PR):
CI should now pass (pending re-run). |
3 tasks
konsisumer
force-pushed
the
fix/slack-reply-in-thread-bridge
branch
3 times, most recently
from
April 11, 2026 23:49
46f4b64 to
0d6451a
Compare
Setting `slack.reply_in_thread: false` in config.yaml had no effect
because the key was not included in the generic platform config bridging
logic. The Slack adapter reads `reply_in_thread` from the platform extra
dict (`self.config.extra.get("reply_in_thread", True)`), but the config
loader only bridged require_mention, free_response_channels,
mention_patterns, reply_prefix, and unauthorized_dm_behavior — not
reply_in_thread.
Add reply_in_thread to the bridged keys so that top-level platform
config (e.g. `slack.reply_in_thread: false`) is propagated to the
platform extra dict where the adapter reads it.
Closes NousResearch#7532
konsisumer
force-pushed
the
fix/slack-reply-in-thread-bridge
branch
from
April 12, 2026 00:06
0d6451a to
51e2053
Compare
The whatsapp-bridge's @whiskeysockets/baileys depends on libsignal via a git+ssh URL. Without git in the image, npm install fails with ENOENT.
6 tasks
Contributor
Author
|
Closing — both changes in this PR are already on
The branch is 474 commits behind main, making a rebase impractical and unnecessary since the substantive work has already shipped. #7532 can be considered resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slack.reply_in_thread: falsein config.yaml had no effect because the key was missing from the generic platform config bridging logic ingateway/config.pyreply_in_threadfromself.config.extra, but the config loader never bridged it from the top-levelslack:block — so the defaultTruealways wonreply_in_threadto the bridged keys alongside the existingrequire_mention,free_response_channels, etc.Closes #7532
Test plan
test_bridges_reply_in_thread_from_slack_configtest verifies the key is bridged correctlytest_config.pytests pass