fix(cli): dispatch /background inline while agent is running (#75221) - #75303
Closed
cipheraxat wants to merge 1 commit into
Closed
fix(cli): dispatch /background inline while agent is running (#75221)#75303cipheraxat wants to merge 1 commit into
cipheraxat wants to merge 1 commit into
Conversation
Classic CLI queued /background (/bg, /btw) on _pending_input during an active turn, so the independent task only started after chat() returned. Mirror the /steer Enter-path early dispatch so the mid-run-safe handler runs immediately. Fixes NousResearch#75221.
alt-glitch
added
type/bug
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/background(/bg,/btw) inline while a foreground turn is running, mirroring the existing/steerpath from fix(cli): dispatch /steer inline while agent is running #13354._pending_inputuntilchat()returns, which defeated mid-run background work.tests/cli/test_cli_background_busy_path.py.Fixes #75221.
Test plan
scripts/run_tests.sh tests/cli/test_cli_background_busy_path.py tests/cli/test_cli_steer_busy_path.py -q(17 passed)hermes, submit a long prompt, while running enter/bg say hi— expect immediate “Background task #N started” before the foreground turn finishesbusy_input_mode(queue/steer/interrupt) and is not affected/backgroundstill works via normalprocess_command