fix(cli): Docker cleanup config propagation - #75296
Open
MichaelHuangXiaofei wants to merge 1 commit into
Open
Conversation
MichaelHuangXiaofei
marked this pull request as ready for review
July 31, 2026 07:26
teknium1
reviewed
Jul 31, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for tracing both creation paths. The lifecycle propagation premise is confirmed on current main: tools/code_execution_tool.py:771 and tools/file_tools.py:1046 omit these flags, while tools/terminal_tool.py:1596-1609 defaults omitted values to true.
Problems
tools/file_tools.py:96andtools/file_tools.py:1288contain unrelated accidental line splits that corrupt the existingnext_offsetcomments.
Suggested changes
- Restore those two comments unchanged; the two
container_configadditions and regression coverage otherwise address the verified missing paths. The other source creation paths already forward both values (agent/prompt_builder.py:1086-1087,tools/terminal_tool.py:2389-2390).
Automated hermes-sweeper review.
| that fits within ``max_chars`` and reports how many lines were kept so | ||
| the caller can offer a ``next_offset`` continuation. | ||
| the caller can offer a ` | ||
| ext_offset`` continuation. |
Contributor
There was a problem hiding this comment.
This unrelated newline corrupts the existing next_offset comment. Please restore it unchanged; the same accidental split also appears at new-side line 1288.
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75291
What changed
docker_persist_across_processesfrom file-tool andexecute_codeDocker creation paths.docker_orphan_reaperthrough the same paths.Root cause
Both paths built a partial
container_config. The missing settings fell back toterminal_tooldefaults, so an explicitdocker_persist_across_processes: falsewas silently treated astrue, leaving the container running and reusable.Validation
venv\\Scripts\\python.exe -m pytest tests/tools/test_docker_config_propagation.py tests/tools/test_docker_orphan_reaper_integration.py -q7 passed