Skip to content

fix(tools): strip PYTHONPATH from subprocess env to prevent leak (#74817) #74951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
webtecnica wants to merge 1 commit into from
+1 −1
Closed

fix(tools): strip PYTHONPATH from subprocess env to prevent leak (#74817) #74951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/environments/local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ def _build_provider_env_blocklist() -> frozenset:
# to a different Python version overwrites it and breaks the gateway). The
# Hermes venv stays reachable via PATH (its bin dir is first), so stripping
# these markers is safe and only prevents the cross-project clobber (#23473).
_ACTIVE_VENV_MARKER_VARS = ("VIRTUAL_ENV", "CONDA_PREFIX")
_ACTIVE_VENV_MARKER_VARS = ("VIRTUAL_ENV", "CONDA_PREFIX", "PYTHONPATH")

@teknium1 teknium1 Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes all PYTHONPATH entries, including user/package-manager paths. execute_code intentionally allows PYTHONPATH (tools/code_execution_tool.py:148-150), and the Nix wrapper appends it for extraPythonPackages plugin discovery (nix/hermes-agent.nix:116-121, 206-208). Please filter only Hermes-injected incompatible site-packages entries and cover the separate execute_code path.



def _is_hermes_internal_secret(key: str) -> bool:
Expand Down
Loading