Skip to content

[verified] fix(kanban): preserve initial blocked state - #74839

Closed
nastiai wants to merge 1 commit into
NousResearch:mainfrom
nastiai:fix/kanban-initial-blocked-sticky
Closed

[verified] fix(kanban): preserve initial blocked state#74839
nastiai wants to merge 1 commit into
NousResearch:mainfrom
nastiai:fix/kanban-initial-blocked-sticky

Conversation

@nastiai

@nastiai nastiai commented Jul 30, 2026

Copy link
Copy Markdown

What does this PR do?

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

@alt-glitch alt-glitch added type/bug Something isn't working comp/cron Cron scheduler and job management P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels Jul 30, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #34735: both emit the missing create-time blocked event so initially blocked cards remain sticky. #34735 is the focused canonical implementation; the extra promote_task transaction work here should be split into a separate change.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for verifying a real current-main defect: create_task(initial_status="blocked") stores a blocked task at hermes_cli/kanban_db.py:3084-3089, but only emits created at hermes_cli/kanban_db.py:3172-3191. Since _has_sticky_block() relies on blocked/unblocked events (hermes_cli/kanban_db.py:3979-3985), recompute_ready() can promote the card on its next tick (hermes_cli/kanban_db.py:4023-4071).

Problems

Suggested changes

Automated hermes-sweeper review.

@teknium1 teknium1 added sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Jul 30, 2026
@nastiai nastiai closed this Jul 31, 2026
@nastiai

nastiai commented Jul 31, 2026

Copy link
Copy Markdown
Author

Closing as a duplicate of #34735. The independent promote_task transaction/race fix has been split into a focused follow-up branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cron Cron scheduler and job management duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants