test(mcp): add regression tests for tool-level error breaker fix - #74770
Closed
x7peeps wants to merge 1 commit into
Closed
test(mcp): add regression tests for tool-level error breaker fix#74770x7peeps wants to merge 1 commit into
x7peeps wants to merge 1 commit into
Conversation
- test_tool_level_errors_do_not_trip_server_breaker (original PR test) - test_mixed_success_and_tool_errors_reset_breaker: alternating isError/success sequences exercise the reset-on-every-result path - test_tool_errors_do_not_count_toward_breaker_threshold: THRESHOLD tool-level errors followed by THRESHOLD transport exceptions exercise the boundary between the two error classes - test_session_recovers_after_isError_then_transport_failure: dead session probe + manual reset verifies post-fix state machine works - test_tool_errors_after_transport_recovery_keep_breaker_closed: many isError results after breaker recovery must not re-open it All 12 circuit breaker tests + 41 total in the MCP test suite pass.
alt-glitch
added
type/bug
Collaborator
Duplicate of the #74045 / #74606 / #61555 family: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends PR #74606 with additional regression tests for the MCP circuit breaker fix:
Verification:
41 passedacross circuit breaker and failure classification tests.