fix(mcp): don't trip circuit breaker on tool errors - #74718
Closed
renga-mn-agent wants to merge 1 commit into
Closed
fix(mcp): don't trip circuit breaker on tool errors#74718renga-mn-agent wants to merge 1 commit into
renga-mn-agent wants to merge 1 commit into
Conversation
Author
|
Closing this PR to recreate it from the intended contributor account. |
19 tasks
Author
|
Replacement: #74795, authored by @renga-kogahara. |
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Treats completed MCP
CallToolResult(isError=True)responses as tool/domain errors rather than server connectivity failures.A completed RPC proves the MCP transport is reachable. Counting a tool-level validation error toward the server circuit breaker can incorrectly mark a healthy MCP server as unreachable and prevent subsequent valid calls.
Related Issue
N/A
Type of Change
Changes Made
tools/callRPC, includingisError=Trueresults.How to Test
.venv/bin/python -m pytest tests/tools/test_mcp*.py -q -o 'addopts='.CallToolResult(isError=True)responses do not open the server connectivity breaker.Focused result:
385 passed.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — docstrings updatedcli-config.yaml.exampleif I added/changed config keys — N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — N/AScreenshots / Logs
N/A