fix(tui): split terminal tab title from window title - #74683
Merged
Conversation
Terminal.app truncates background tab titles from the left, so a single long OSC 0 string (marker · session · model · cwd) leaves only the tail visible — usually the cwd or process name. Emit OSC 1 (icon/tab) with just the short session title and OSC 2 (window) with the full composed string, so background tabs show the session name instead of the cwd tail.
Contributor
૮ >ﻌ< ა ci reviewran on f1a91ad ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence upload failed. Failed to upload diff-665a0833239e-onboarding-overlay-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-665a0833239e-onboarding-overlay-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso) |
This was referenced Jul 30, 2026
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
fix(tui): split terminal tab title from window title
33hodl
pushed a commit
to 33hodl/hermes-agent
that referenced
this pull request
Aug 12, 2026
fix(tui): split terminal tab title from window title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Terminal.app truncates background tab titles from the left. The TUI was emitting a single OSC 0 (set title+icon) with the full composed string
marker · sessionTitle · model · cwd, so a background tab only showed the tail — usually the cwd or process name likepython— instead of the session name at the front.useTerminalTitlenow accepts{ tab, window }to emit two separate sequences:⏳ session title⏳ session title · model · cwdBackground tabs now show the session name. The window title bar keeps the full string. When a single string is passed (existing callers), behavior is unchanged — still OSC 0.
How to test
Cmd+I) — should show the fullmarker · session · model · cwdstring.Related — superseded PRs
This PR fixes the TUI (Ink/React) tab title. The classic CLI (prompt_toolkit) is a separate code path — #74654 is the complementary CLI implementation and remains open.
The following stale CLI PRs were closed as superseded by #74654:
#5505 (the feature issue) stays open until #74654 merges for the CLI side; the TUI side is fixed here.