Skip to content

Put YOLO in ⌘K and show each toggle's live state - #74674

Merged
OutThisLife merged 7 commits into
mainfrom
bb/yolo-palette
Jul 30, 2026
Merged

Put YOLO in ⌘K and show each toggle's live state#74674
OutThisLife merged 7 commits into
mainfrom
bb/yolo-palette

Conversation

@OutThisLife

@OutThisLife OutThisLife commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

YOLO had a status-bar zap and a slash command but was never registered as a palette contribution, so ⌘K couldn't reach it. Adding it turned up three things worth fixing around it.

The rows didn't say where they stood. "Toggle status bar" tells you what the row does but not which way it will go. Palette rows already carry a detail slot for trailing notes, so paletteToggle fills it with the live on/off. A toggle's note isn't a passive fact like a version string though — the row is about to change it — so it keeps the label's color and separates with a faint underline instead of going muted. Both variants live in floating-hud.ts beside the other shared HUD chrome. Status bar, logs, and layout edit mode go through the same helper, and flipping one no longer closes the palette, matching what the theme rows already did.

Branch rows outranked everything. Group order is the only tiebreaker rankGroups has (stable sort), and ties are the common case — yolo matches both "Toggle YOLO" and a worktree named bb/yolo-palette as a whole word. The branch group sat second and won, burying the command under a list that grows with whatever's checked out. The order now reads as the priority it always was: where you're going, what you can do, what you can configure, then the typed-only lists, and branches last.

Labels that describe live state now name the direction. The sidebar rail and project disclosures read "Show" or "Hide" from what's actually on screen, and a failed write says which direction failed instead of "Failed to toggle". All five locales.

The last commit is naming only: toggleSkill(name, enabled) is a setter wearing a toggle's name. A toggle takes no argument; anything handed an explicit value is a set.

Test plan

  • ⌘K shows Toggle yolo trailed by an underlined off; run it — the palette stays open and the note flips to on, and the status-bar zap agrees
  • Same for Toggle status bar, Toggle logs, Toggle layout edit mode
  • With a worktree checked out, typing yolo puts Toggle yolo above the branch rows
  • The Update row's version note is still muted, not underlined
  • Sidebar rail tooltip reads "Show sidebar" when collapsed, "Hide sidebar" when open

@OutThisLife OutThisLife changed the title Give every ⌘K toggle an explicit on and off row Make ⌘K toggles say what they'll do Jul 30, 2026
@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) labels Jul 30, 2026
YOLO had a status-bar zap and a slash command but was never registered as a
palette contribution, so ⌘K couldn't reach it.

Adding it exposed the wider gap: "Toggle status bar" doesn't say which way it
will go. Rows already carry a muted `detail` slot, so paletteToggle fills it
with on/off — no new chrome, and the verb stays. Status bar, logs, and layout
edit mode go through the same helper.
The sidebar rail, project disclosures, and the toolset switch now read "Show" or
"Hide" from what's actually on screen, and a failed write says which direction
failed instead of "Failed to toggle". All five locales.
toggleSkill(name, enabled) is a setter wearing a toggle's name. A toggle takes
no argument; anything handed an explicit value is a set.
@OutThisLife OutThisLife changed the title Make ⌘K toggles say what they'll do Put YOLO in ⌘K and show each toggle's live state Jul 30, 2026
Group order is the only tiebreaker rankGroups has (stable sort), and ties are
the common case: "yolo" matches both "Toggle YOLO" and a worktree named
bb/yolo-palette as a whole word. Branch rows sat second and won, burying the
command under a list that grows with whatever's checked out.

The order now reads as the priority: where you're going, what you can do, what
you can configure, then the typed-only lists, and branches last.

Also pulls the muted detail back to ~4px — it reads as a suffix of the label,
not another flex item at the row's icon-to-label gap.
@OutThisLife
OutThisLife force-pushed the bb/yolo-palette branch 2 times, most recently from 1b66d92 to 1b8f6ca Compare July 30, 2026 08:13
…ariant

A toggle's on/off isn't a passive fact like a version string — the row is about
to change it. It keeps the label's color so the two read as one phrase, and
earns its separation from a faint underline instead of going muted. Both
variants live in floating-hud.ts beside the other shared HUD chrome.

That underline needs room to exist: flex items are blockified, so the note's
truncate/overflow-hidden bites, and the app's global 0.25rem offset sits at the
bottom edge of a text-xs line box. The state variant drops truncate (one word,
nothing to clip) and pulls the offset to 2px.

Flipping a setting isn't navigation either, so toggles keep the palette open the
way the theme and color-mode rows already do, and selecting a keepOpen row bumps
a counter that rebuilds the groups so the note can't report the state it left.

Also: yolo is lowercase, and logs gets its own icon instead of borrowing the
YOLO bolt.
# Conflicts:
#	apps/desktop/src/app/command-palette/index.tsx
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on 7996ec6

ℹ️ Info

Desktop E2E visual evidence · View test artifacts · View job

1 visual diff.

inline evidence is publishing...

…nder

These assert the accessible name, and the name now states the action rather
than the word toggle: an enabled toolset offers "Turn X toolset off", a
collapsed project offers "Show X sessions".
@OutThisLife
OutThisLife enabled auto-merge July 30, 2026 09:21
@OutThisLife
OutThisLife merged commit 94924c6 into main Jul 30, 2026
31 checks passed
@OutThisLife
OutThisLife deleted the bb/yolo-palette branch July 30, 2026 09:25
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
Put YOLO in ⌘K and show each toggle's live state
33hodl pushed a commit to 33hodl/hermes-agent that referenced this pull request Aug 12, 2026
Put YOLO in ⌘K and show each toggle's live state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants