Skip to content

fix(desktop): sidebar labels truncate instead of pushing header icons out - #74642

Merged
OutThisLife merged 1 commit into
mainfrom
bb/sidebar-icon-clip
Jul 30, 2026
Merged

fix(desktop): sidebar labels truncate instead of pushing header icons out#74642
OutThisLife merged 1 commit into
mainfrom
bb/sidebar-icon-clip

Conversation

@OutThisLife

Copy link
Copy Markdown
Collaborator

Summary

At narrow sidebar widths a long project title (or lane/section label) refused to shrink — flex's default min-width: auto on the label containers meant the label won the space fight and shoved the header's trailing action icons (disclosure caret, +, kebab, git-branch) past the sidebar edge.

This makes the rule global: labels give way, icons never do.

  • min-w-0 on the section-header label containers (sessions, cron, keybind categories) so each label's truncate can actually engage
  • shrink-0 on DisclosureCaret at the primitive, so every collapsible header keeps its caret for free
  • shrink-0 on SidebarSectionMeta (the loading-glyph slot)
  • overflow-hidden on LaneLabel, whose pinned branch-suffix tail is shrink-0 and could still overflow at extreme widths

All trailing action buttons in these headers were already shrink-0, so with the labels now shrinkable the icons hold at any width.

Test plan

  • Enter a project with a long name, drag the sidebar to minimum width: title ellipsizes, caret/+/kebab stay visible
  • Same for repo/worktree lanes (branch tail stays pinned, clips instead of overflowing) and the cron section header

… out

Flex containers around section/lane labels kept their default min-width:auto,
so a long project title refused to shrink at narrow sidebar widths and shoved
the trailing action icons (caret, +, kebab, branch) past the edge. Give every
header label min-w-0 so its truncate can engage, pin shrink-0 on the caret at
the primitive level and on SidebarSectionMeta, and clip LaneLabel's pinned
tail inside the label. Icons now stay visible at any width.
@OutThisLife
OutThisLife enabled auto-merge July 30, 2026 06:22
@alt-glitch alt-glitch added type/bug Something isn't working comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have labels Jul 30, 2026
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on 958ab81

ℹ️ Info

Desktop E2E visual evidence · View test artifacts · View job

1 visual diff.

inline evidence is publishing...

@OutThisLife
OutThisLife merged commit 1e2d550 into main Jul 30, 2026
36 checks passed
@OutThisLife
OutThisLife deleted the bb/sidebar-icon-clip branch July 30, 2026 07:04
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
…on-clip

fix(desktop): sidebar labels truncate instead of pushing header icons out
33hodl pushed a commit to 33hodl/hermes-agent that referenced this pull request Aug 12, 2026
…on-clip

fix(desktop): sidebar labels truncate instead of pushing header icons out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants