fix(desktop): sidebar labels truncate instead of pushing header icons out - #74642
Merged
Conversation
… out Flex containers around section/lane labels kept their default min-width:auto, so a long project title refused to shrink at narrow sidebar widths and shoved the trailing action icons (caret, +, kebab, branch) past the edge. Give every header label min-w-0 so its truncate can engage, pin shrink-0 on the caret at the primitive level and on SidebarSectionMeta, and clip LaneLabel's pinned tail inside the label. Icons now stay visible at any width.
OutThisLife
enabled auto-merge
July 30, 2026 06:22
Contributor
૮ >ﻌ< ა ci reviewran on 958ab81 ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence is publishing... |
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…on-clip fix(desktop): sidebar labels truncate instead of pushing header icons out
33hodl
pushed a commit
to 33hodl/hermes-agent
that referenced
this pull request
Aug 12, 2026
…on-clip fix(desktop): sidebar labels truncate instead of pushing header icons out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
At narrow sidebar widths a long project title (or lane/section label) refused to shrink — flex's default
min-width: autoon the label containers meant the label won the space fight and shoved the header's trailing action icons (disclosure caret, +, kebab, git-branch) past the sidebar edge.This makes the rule global: labels give way, icons never do.
min-w-0on the section-header label containers (sessions, cron, keybind categories) so each label'struncatecan actually engageshrink-0onDisclosureCaretat the primitive, so every collapsible header keeps its caret for freeshrink-0onSidebarSectionMeta(the loading-glyph slot)overflow-hiddenonLaneLabel, whose pinned branch-suffix tail isshrink-0and could still overflow at extreme widthsAll trailing action buttons in these headers were already
shrink-0, so with the labels now shrinkable the icons hold at any width.Test plan