fix(desktop): focus the tab restored by undo-close (⌘⇧T) - #74640
Merged
Conversation
Adoption alone is silent, so reopenLastClosedTile only restored placement and left the tab behind the still-fronted workspace. Focus it after open.
OutThisLife
enabled auto-merge
July 30, 2026 06:15
alt-glitch
added
type/bug
Contributor
૮ >ﻌ< ა ci reviewran on 7556c51 ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence is publishing... |
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…-tab-focus fix(desktop): focus the tab restored by undo-close (⌘⇧T)
33hodl
pushed a commit
to 33hodl/hermes-agent
that referenced
this pull request
Aug 12, 2026
…-tab-focus fix(desktop): focus the tab restored by undo-close (⌘⇧T)
prmartinow
pushed a commit
to prmartinow/hermes-agent
that referenced
this pull request
Aug 26, 2026
…-tab-focus fix(desktop): focus the tab restored by undo-close (⌘⇧T)
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…-tab-focus fix(desktop): focus the tab restored by undo-close (⌘⇧T)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$sessionTiles. Pane adoption is silent, so the tab came back behind the still-fronted workspace.reopenLastClosedTilenow callsfocusOpenSessionafter open so the restored tab is fronted and its zone is the focus target again.Test plan
vitest run src/store/session-states.test.ts(reopen-focus case)