fix(cron): keep scheduler jobs outside child context - #74600
Closed
TheNewBee wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for investigating the ContextVar boundary. The scheduler does copy the caller context at Problems
Suggested changes
This is an automated hermes-sweeper review. |
This was referenced Aug 1, 2026
Author
|
You are right. I cannot identify a first-party production path that enters scheduler tick() with the delegated-child marker set. The added test directly invoked tick() inside delegated_child_context(), so it does not establish the reported production trigger. I am closing this instead of weakening the scheduler authority boundary; a future report will need a real production-path reproduction before reopening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tick()from propagating a delegated-child ContextVar into scheduler-owned cron jobsVerification
python3 -m pytest -q tests/cron/test_run_one_job.py(4 passed)python3 -m py_compile agent/delegation_context.py cron/scheduler.pygit diff --checkThis fixes PM cron Kanban closure being denied solely because
contextvars.copy_context()carried a surroundingdelegate_taskchild marker into the scheduler worker.