fix(packaging): add missing hermes_state_* modules to py-modules list (#74287) - #74492
Closed
RelaxJonh wants to merge 1 commit into
Closed
fix(packaging): add missing hermes_state_* modules to py-modules list (#74287)#74492RelaxJonh wants to merge 1 commit into
RelaxJonh wants to merge 1 commit into
Conversation
Collaborator
hermes_state.py imports four sibling modules that are not listed in [tool.setuptools] py-modules, so they are never packaged in wheel/sdist builds. Any install built from pyproject.toml (pip/uv wheel, nix, distro packaging) silently disables the SQLite session store because the modules are missing from the distribution. - hermes_state_common (re-exported for back-compat) - hermes_state_portability (SessionPortabilityMixin) - hermes_state_schema (SessionSchemaMixin) - hermes_state_search (SessionSearchMixin) Git installs are unaffected since they run from the repo tree. Fixes NousResearch#74287
RelaxJonh
force-pushed
the
fix/py-modules-missing-hermes-state-74287
branch
from
July 30, 2026 02:24
2a47363 to
aae73af
Compare
This was referenced Jul 30, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes_state.pyimports four sibling top-level modules that are not listed in[tool.setuptools] py-modules, so they are never packaged in wheel/sdist builds. Any install built frompyproject.toml(pip/uv wheel, nix, distro packaging) silently disables the SQLite session store because the modules are missing from the distribution.Git installs are unaffected since they run from the repo tree where the files are present.
Root Cause
hermes_state.pyimports:hermes_state_common(line 46, re-exported for back-compat)hermes_state_portability(line 70,SessionPortabilityMixin)hermes_state_schema(line 71,SessionSchemaMixin)hermes_state_search(line 72,SessionSearchMixin)But
pyproject.tomlline 348 only listshermes_state— the four dependencies are absent.Fix
Add the four missing modules to the
py-moduleslist inpyproject.toml.Testing
tests/test_packaging_build_guard.py)hermes_state.pymatch the added module namesFixes #74287