Desktop: platforms.changed broadcast retires the Messaging page's 6s status poll - #74422
Merged
Conversation
…'s 6s status poll The change watcher (#73673) missed one always-on-while-mounted timer: the Messaging page polled /api/messaging/platforms every 6s for connection status. The gateway already persists platform connect/disconnect/health to gateway_state.json, so watch that file's mtime and broadcast platforms.changed (floored to 5s — the gateway also rewrites the file for in-flight-count bookkeeping), route it through live-sync like its siblings, and refresh the page on the tick. Older backends keep the legacy visible-tab poll verbatim. Finishes the always-on poll sweep for #73618.
Contributor
૮ >ﻌ< ა ci reviewran on f8e07a3 ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence upload failed. Failed to upload diff-665a0833239e-onboarding-overlay-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-665a0833239e-onboarding-overlay-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso) |
alt-glitch
added
type/perf
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…changed Desktop: platforms.changed broadcast retires the Messaging page's 6s status poll
33hodl
pushed a commit
to 33hodl/hermes-agent
that referenced
this pull request
Aug 12, 2026
…changed Desktop: platforms.changed broadcast retires the Messaging page's 6s status poll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #73673, which missed one always-on-while-mounted timer: the Messaging page polled
/api/messaging/platformsevery 6s for connection status while open.The gateway already persists platform connect/disconnect/health to
gateway_state.json— so the change watcher gains a fourth signature and the page becomes event-driven like its siblings:platforms.changedgateway_state.jsonmtime moves — a platform connects, disconnects, or its health flips{}(nudge; the page refetches)Renderer:
$platformsChangeTickinstore/live-sync.ts, routed ingateway-event.tswith the same active-profile gate, consumed by the Messaging page. Event-capable backend → no timer at all; older backend → the legacy 6s visible-tab poll, verbatim.Validation:
test_gateway_state_move_broadcasts_platforms_changedjoins the change-watcher contract suite (real tempHERMES_HOME); messaging + contrib-hooks vitest suites green.