Skip to content

[withdrawn] PR #74168 - #74168

Closed
e-shizz wants to merge 2 commits into
NousResearch:mainfrom
e-shizz:lumi/desktop-terminal-nerd-font
Closed

[withdrawn] PR #74168#74168
e-shizz wants to merge 2 commits into
NousResearch:mainfrom
e-shizz:lumi/desktop-terminal-nerd-font

Conversation

@e-shizz

@e-shizz e-shizz commented Jul 29, 2026

Copy link
Copy Markdown

Withdrawn by author. The source fork has been removed.

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) area/i18n Localization, locales, translations labels Jul 29, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for covering both Desktop terminal surfaces and all supported locales. The feature premise is present on current main: apps/desktop/src/app/right-sidebar/terminal/use-terminal-session.ts:509 and apps/desktop/src/app/right-sidebar/terminal/use-agent-terminal.ts:48 each hardcode the bundled JetBrains Mono stack.

Problems

  • apps/desktop/src/store/terminal-font.test.ts covers persisted state and the returned font stack, but not the new live renderer behavior in use-terminal-session.ts and use-agent-terminal.ts: updating fontFamily, refitting, clearing the WebGL atlas, and refreshing. That is the user-visible behavior this feature adds.

Suggested changes

  • Add a mocked xterm/hook test that toggles the preference after mount and asserts those operations for both terminal variants, without creating a replacement terminal instance.

GitHub currently marks the branch as merge-conflicting, so salvage will require resolving its overlap with current main. This is an automated hermes-sweeper review.

@teknium1 teknium1 added the sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users label Jul 30, 2026
@e-shizz e-shizz closed this Aug 4, 2026
@e-shizz e-shizz changed the title feat(desktop): add optional Nerd Font terminal [withdrawn] PR #74168 Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/i18n Localization, locales, translations comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants