Skip to content

fix(tests): use the platform temp dir for the isolation-probe handoff #74083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyqqx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tests): use the platform temp dir for the isolation-probe handoff #74083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions tests/test_run_tests_parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import os
import subprocess
import sys
import tempfile
import textwrap
import time
from pathlib import Path
Expand All @@ -32,9 +33,14 @@


# Both tests share the same handoff file: the leaker writes here, the
# verifier reads here. We park it in $TMPDIR with a unique-per-run name
# so concurrent invocations of the suite don't clobber each other.
_HANDOFF_DIR = Path(os.environ.get("TMPDIR", "/tmp")) / "hermes-isolation-probe"
# verifier reads here. We park it in the platform temp dir with a
# unique-per-run name so concurrent invocations of the suite don't clobber
# each other. gettempdir() still honours $TMPDIR first, so POSIX behaviour is
# unchanged; on Windows TMPDIR is normally unset and the old "/tmp" fallback
# resolved to a non-existent \tmp on the current drive, raising here at import
# time — before the skipif below could be evaluated — which aborts collection
# for the entire suite.
_HANDOFF_DIR = Path(tempfile.gettempdir()) / "hermes-isolation-probe"
_HANDOFF_DIR.mkdir(exist_ok=True)


Expand Down