fix(infra): salvage Docker/install PRs #6934 #6910 #6904 + entrypoint dirs from #6936 - #7407
Merged
Conversation
Playwright's --with-deps flag only supports apt-based dependency installation. The install script previously ran it on all non-Arch systems, failing silently on Gentoo, Fedora, openSUSE, and others. - Restrict --with-deps to known apt-based distributions - Add explicit guidance for RPM-based (dnf) and zypper-based systems - Show visible warnings instead of suppressing failures with || true - Correct misleading comment that claimed dnf/zypper support Fixes #6865
…d lifetime Two issues with sandbox container spawning: 1. PID 1 was `sleep 2h` which doesn't call wait() — every background process that exited became a zombie (<defunct>), and the process tool reported them as "running" because zombie PIDs still exist in the process table. Fix: add --init to docker run, which uses tini (Docker) or catatonit (Podman) as PID 1 to reap children automatically. Both runtimes support --init natively. 2. The fixed 2-hour lifetime was arbitrary and sometimes too short for long agent sessions. Fix: replace 'sleep 2h' with 'sleep infinity'. The idle reaper (_cleanup_inactive_envs, gated by terminal.lifetime_seconds, default 300s) already handles cleanup based on last activity timestamp — there's no need for the container itself to have a fixed death timer. Fixes #6908.
Add the [socks] extra to the httpx dependency to include the required 'socksio' package. This fixes the error: "Using SOCKS proxy, but the 'socksio' package is not installed" when users configure SOCKS proxy settings.
The profile system expects these directories but they weren't being created on container startup. Adds them to the mkdir list alongside the existing dirs. Co-authored-by: Tranquil-Flow <tranquil_flow@protonmail.com>
This was referenced Apr 10, 2026
malaiwah
pushed a commit
to malaiwah/hermes-agent
that referenced
this pull request
Apr 12, 2026
- find_podman() now checks for both `podman` and `podman-remote` in PATH and search paths. This supports gateway deployments where the hermes container has podman-remote but not podman (e.g. our Alpine LXC setup where podman-remote talks to the host Podman socket). - Add --init flag to PodmanEnvironment._build_run_cmd() for zombie reaping, matching the Docker backend (merged in NousResearch#7407). - Add test for podman-remote discovery. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of 4 infra PRs. Contributor authorship preserved.
Cherry-picked:
fix(install): handle Playwright deps correctly on non-apt systems #6934 (Tranquil-Flow) — Playwright
--with-depsonly works on apt-based systems. Restricts it to known apt distros, adds manual dep instructions for dnf/zypper, replaces silent|| truewith visible warnings.fix(docker): --init for zombie reaping + sleep infinity for idle-based lifetime #6910 (malaiwah) — Adds
--initflag for zombie reaping (tini as PID 1) and changessleep 2htosleep infinity(lets the existing idle reaper handle lifecycle). Two lines.fix(deps): add socks extra to httpx for SOCKS proxy support #6904 (duerzy) — Adds
[socks]extra to httpx dependency for SOCKS proxy support. One character.Partial salvage from #6936 (Tranquil-Flow) — Added missing
skins,plans,workspacedirectories to entrypoint.sh mkdir. Left HERMES_HOME hardcoded as-is.No test changes needed — all changes are in Docker/install/deps config.