fix(desktop): flip zone collapse chevron to action direction - #74007
fix(desktop): flip zone collapse chevron to action direction#74007chillerno1 wants to merge 2 commits into
Conversation
Collapsed tool zones (terminal/logs) kept a down chevron after minimize, so the restore affordance looked like another collapse. Point the icon in the action direction — down when expanded, up when collapsed — matching master-detail collapsible detail headers. Same fix for floating panes.
|
Reviewed against #74006 — this correctly resolves it. The flip Nice that it fixes both surfaces in one pass — the docked/tool-zone strip in One minor coverage note (non-blocking): the added assertions live in Otherwise LGTM. |
|
Thanks for the focused fix. Static review confirms the action direction is correct: Suggested changes
Automated hermes-sweeper review. |
|
@teknium1 have added the direct regression test as suggested |
|
Thanks for this fix! It was salvaged into #86771 (cherry-picked onto current main with your authorship preserved in the commit history) and is now merged. Closing since the work has landed. |
Summary
Fixes #74006
Test plan
NODE_OPTIONS='--localstorage-file=/tmp/hermes-vitest-ls.json' npm run test:ui -- src/components/pane-shell/tree/renderer/floating-panes.test.tsx(8 passed)