Skip to content

refactor: remove the claude-marketplace skill source (broken 1-entry Marketplace hub tab) - #73903

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-1c8e0a30
Jul 29, 2026
Merged

refactor: remove the claude-marketplace skill source (broken 1-entry Marketplace hub tab)#73903
teknium1 merged 1 commit into
mainfrom
hermes/hermes-1c8e0a30

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

Removes the claude-marketplace skill source, whose Skills Hub "Marketplace" tab had degenerated to a single broken entry.

Root cause: Anthropic changed .claude-plugin/marketplace.json to bundle-shaped plugins (source: "./" + a skills: array), so all plugins collapsed to one identifier pointing at the repo root; the only other marketplace repo (aiskillstore/marketplace) is gone (404). Everything in anthropics/skills is already surfaced by the GitHub tap as the Anthropic tab (17 skills live), making this source fully redundant.

Changes

  • tools/skills_hub.py: delete ClaudeMarketplaceSource (~104 lines) + source-router entry + _api_source_ids entry
  • scripts/build_skills_index.py: drop crawl entry, source limit, sort order, rate-limit messaging
  • website/scripts/extract-skills.py: drop label mappings, install-command branch, source-URL branch
  • website/src/pages/skills/index.tsx: remove the "Marketplace" tab config + SOURCE_ORDER entry
  • hermes_cli/web_server.py, hermes_cli/skills_hub.py: drop labels / per-source limits
  • website/docs (en + zh): remove the claude-marketplace source section, renumber siblings
  • skills/index-cache/claude_marketplace_anthropics_skills.json: delete legacy snapshot
  • tests/scripts/test_build_skills_index_health.py: update fixtures/invariants

Validation

Before After
Marketplace tab 1 broken entry (repo-root link) tab removed; Anthropic tab (17) covers the content
Targeted tests 206/206 pass (build-index health, extract-skills, skills_hub x2)
E2E source router builds without the source; build/extract scripts import clean; straggler grep = 0 hits

Back-compat: stale index entries with source: "claude-marketplace" still install — HermesIndexSource.fetch() resolves via GitHub paths generically.

Infographic

Removing the Marketplace skill source

…tplace hub tab)

The Skills Hub 'Marketplace' tab showed a single useless entry: Anthropic
changed .claude-plugin/marketplace.json to bundle-shaped plugins whose
source is './', so all plugins collapsed to one identifier pointing at the
repo root, and the second marketplace repo (aiskillstore/marketplace) is
gone (404). Everything in anthropics/skills is already surfaced by the
GitHub tap as the Anthropic tab, making this source fully redundant.

Removes ClaudeMarketplaceSource and all wiring: source router, index
builder (crawl + floors + sort order + rate-limit messaging), extract
labels/install/URL mapping, hub UI tab, web server labels, CLI limits,
docs (en + zh), the legacy index-cache snapshot, and test fixtures.

Stale skills-index entries with source 'claude-marketplace' still install
fine: HermesIndexSource fetches via resolved GitHub paths generically.
@teknium1
teknium1 force-pushed the hermes/hermes-1c8e0a30 branch from ce955be to 104cccd Compare July 29, 2026 05:54
@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) labels Jul 29, 2026
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on 104cccd

ℹ️ Info

Desktop E2E visual evidence · View test artifacts · View job

1 visual diff.

inline evidence upload failed.

Failed to upload diff-665a0833239e-onboarding-overlay-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-665a0833239e-onboarding-overlay-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants