fix(desktop): keep queued drains out of the foreground session on session switch

[OutThisLife]

A queue drain pairs two identifiers that move on different clocks: the queue key flips with the route, while the explicit runtime id lags a resume behind. Mid-switch the composer can fire a drain carrying session B's queue key alongside session A's runtime id, and prompt.submit then lands B's queued prompt — and its entire answer turn — inside A. The existing guard only covered the case where the runtime id came through null; this closes the remaining case where it is non-null and stale.

Supersedes #69049 by @theone139344, whose diagnosis and fix this builds on directly.

The fix

use-prompt-actions/submit.ts treated an explicit options.sessionId as authoritative and never checked it against getRuntimeIdForStoredSession. Queued sends now verify the pair against the central runtime↔stored-session binding:

• pair matches the binding → proceed unchanged
• binding exists but differs → adopt the bound runtime id
• no binding recorded → drop the stale id and re-home through the stored-session resume path, the same fallback the background drain already uses
• identity pairs (storedSessionId === sessionId, a brand-new unsaved chat) pass through untouched

The check is scoped to fromQueue. Only a drain pairs ids from two clocks; every other explicit-target caller resolves both in the same tick and is authoritative by construction. A slash skill dispatch into a fresh ⌘T tab passes the same shape — sessionId=tab-runtime, storedSessionId=tab-stored, no binding recorded yet — so an unscoped check nulls the target and silently drops the kickoff.

Changes from #69049

• gate the binding check on fromQueue, with the scoping invariant covered by a test
• refresh the two drain tests for queued: true, which prompt.submit started sending for queued drains in ab68c5e after that branch was cut
• fix the mock signatures so tsc --noEmit is clean

Verification

use-prompt-actions, use-background-queue-drain, composer-queue, and use-session-state-cache — 182 passing. tsc -p apps/desktop --noEmit clean.

[github-actions]

૮ >ﻌ< ა ci review

_{ran on 8830f22}

ℹ️ Info

Desktop E2E visual evidence · View test artifacts · View job

1 visual diff.

_{inline evidence upload failed.}

Failed to upload diff-665a0833239e-onboarding-overlay-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-665a0833239e-onboarding-overlay-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso)