Skip to content

fix(photon): restore placeholder and sidecar tests #73799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
psionic73 wants to merge 1 commit into from
Closed

fix(photon): restore placeholder and sidecar tests #73799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/platforms/photon/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,9 +885,9 @@ def _normalize_binary_payload(
# arrives while that turn is active and the gateway sends a bogus
# "Interrupting current task" busy ack. Drop placeholder-only text
# at the platform boundary; the real media event carries the bytes.
if raw_text.strip() == "\ufffc":
logger.debug("[photon] ignoring iMessage object-placeholder text event")
return
# Placeholder-only text is handled just below: create a short-lived
# pending entry so a following attachment can cancel the timeout.
# Do not return here or the timeout/correlation state is skipped.
if ctype == "reaction":
# Route only tapbacks on messages WE sent — those are implicitly
# addressed to the bot (feishu precedent: synthetic text event).
Expand Down
2 changes: 1 addition & 1 deletion tests/plugins/platforms/photon/test_runtime_record.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def _patch_spawn(
) -> None:
"""Stub everything _start_sidecar touches before the healthz loop."""
sidecar_dir = tmp_path / "sidecar"
(sidecar_dir / "node_modules").mkdir(parents=True)
(sidecar_dir / "node_modules" / "spectrum-ts").mkdir(parents=True)
monkeypatch.setattr(photon_adapter, "_SIDECAR_DIR", sidecar_dir)
monkeypatch.setattr(photon_adapter, "_sidecar_deps_stale", lambda: False)

Expand Down
Loading