Skip to content

fix(photon): repair two cross-PR collisions from the photon wave (U+FFFC shadow + runtime-record fixture) #73773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
teknium1 wants to merge 2 commits into from
Closed

fix(photon): repair two cross-PR collisions from the photon wave (U+FFFC shadow + runtime-record fixture) #73773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa35c31
fix(photon): remove early U+FFFC drop that shadowed the deferred-wait…
teknium1 Jul 29, 2026
f01c938
test(photon): materialize spectrum-ts dir in runtime-record spawn fix…
teknium1 Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions plugins/platforms/photon/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,19 +875,6 @@ def _normalize_binary_payload(
)

ctype = content.get("type")
if ctype == "text":
raw_text = content.get("text") or ""
# iMessage emits U+FFFC OBJECT REPLACEMENT CHARACTER as a transient
# placeholder for some media bubbles (notably voice notes). Photon
# can then deliver the real attachment/voice event immediately
# afterwards with a different message id. If we dispatch the
# placeholder as a standalone text turn, the subsequent media event
# arrives while that turn is active and the gateway sends a bogus
# "Interrupting current task" busy ack. Drop placeholder-only text
# at the platform boundary; the real media event carries the bytes.
if raw_text.strip() == "\ufffc":
logger.debug("[photon] ignoring iMessage object-placeholder text event")
return
if ctype == "reaction":
# Route only tapbacks on messages WE sent — those are implicitly
# addressed to the bot (feishu precedent: synthetic text event).
Expand Down
5 changes: 4 additions & 1 deletion tests/plugins/platforms/photon/test_runtime_record.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,10 @@ def _patch_spawn(
) -> None:
"""Stub everything _start_sidecar touches before the healthz loop."""
sidecar_dir = tmp_path / "sidecar"
(sidecar_dir / "node_modules").mkdir(parents=True)
# sidecar_deps_installed() checks the spectrum-ts package dir, not bare
# node_modules/ (9cf2046081 hardened it against partial npm installs) —
# the fixture must materialize the dependency dir the probe looks for.
(sidecar_dir / "node_modules" / "spectrum-ts").mkdir(parents=True)
monkeypatch.setattr(photon_adapter, "_SIDECAR_DIR", sidecar_dir)
monkeypatch.setattr(photon_adapter, "_sidecar_deps_stale", lambda: False)

Expand Down
Loading