fix(desktop): resume continuous voice listening after playback - #73690
fix(desktop): resume continuous voice listening after playback#73690canderson26 wants to merge 1 commit into
Conversation
32a91a6 to
4d5517b
Compare
|
Thanks for the focused lifecycle fix. The reported premise is present on current main: The PR's post-startup baseline captures and handoff-stop guard address those paths, and its regression matrix covers normal streaming/fallback completion plus the relevant explicit-stop cases. Automated hermes-sweeper review. |
|
Vox Lockin lane 09 verification receipt:
Verdict: intent fully covered by merged #73880 + main's current hook; recommend closing this PR as superseded (no duplicate work opened). |
Summary
nullrather than0as the uninitialized playback-sequence sentinelRoot cause
startSpeechStream()andplaySpeechText()stop/replace existing playback as part of normal startup, which advances$voicePlayback.sequence. Continuous voice captured the sequence before those expected startup bumps, then interpreted normal completion as an explicit user Stop and suppressed the next listening cycle.Blindly recapturing after fallback startup introduced a second race: a real Stop while a failed stream waited to hand off to fallback speech could be erased. The revised hook preserves the streaming baseline, detects that Stop before fallback begins, and settles idle without reopening the microphone.
Test plan
The regression matrix covers normal streaming completion, normal fallback completion, explicit Stop during streaming, explicit Stop during the stream-to-fallback wait, explicit Stop during fallback playback, and disabling voice mode during speech.