fix(cli): repair broken test_migrate_reports in test_config.py - #73630
Closed
webtecnica wants to merge 2 commits into
Closed
fix(cli): repair broken test_migrate_reports in test_config.py#73630webtecnica wants to merge 2 commits into
webtecnica wants to merge 2 commits into
Conversation
The test_migrate_reports_normalized_line_formatting test failed when run as part of the full tests/hermes_cli/ suite due to a stale import reference. Root cause: the test module's top-level import (from hermes_cli.config import migrate_config at line 21) was captured while migrate_config was temporarily patched by a prior test's session-scoped or module-scoped fixture. When the test ran, it called the patched (no-op) version instead of the real function, so the print() inside migrate_config never executed. Fix: re-import migrate_config inside the test method with a local alias, bypassing the stale top-level reference and always getting the current module attribute. Closes NousResearch#73144
alt-glitch
added
type/test
Contributor
|
Thanks for investigating the order-dependent test failure. This is now redundant because the underlying module-identity leak has already been fixed on
|
teknium1
added
the
sweeper:implemented-on-main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #73144