test(tts): fix stale xAI fake_post doubles broken by stream=True (red on main) - #73612
Merged
Conversation
60b841b switched the xAI TTS request to requests.post(..., stream=True) but left four fake_post doubles on the old 4-arg signature — TypeError on every run, red CI slice 5/8 for unrelated PRs. Align them with the ten already-updated fakes in the same file.
alt-glitch
added
type/test
Collaborator
Duplicate of #73594, the earliest open PR fixing the same stale xAI TTS fake-post fixtures. Please consolidate on one implementation. |
Contributor
૮ >ﻌ< ა ci reviewran on 2b4d5ad ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence upload failed. Failed to upload diff-665a0833239e-onboarding-overlay-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-665a0833239e-onboarding-overlay-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repairs 4 tests in
tests/tools/test_tts_xai_speech_tags.pythat are red on current main: commit 60b841b ("fix(tts): bound upstream response bodies") switched the xAI TTS request torequests.post(..., stream=True), but fourfake_postdoubles in this file still had the old 4-arg signature, so they crash withTypeError: unexpected keyword argument 'stream'on every run — failing CI slice 5/8 for unrelated PRs (first seen on docs-only #73571).Changes
stream=Falseto the 4 stalefake_postsignatures (the other 10 fakes in the file were already updated)Validation
Infographic