fix(credits): remove the 'Grant spent · $X top-up left' notice - #73540
Merged
Conversation
The grant_spent notice fired for every subscription user with top-up funds the moment their cap was reached and camped in the CLI/TUI status bar and desktop toasts with no action to take — the account keeps working off top-up. Remove it everywhere: - agent/credits_tracker.py: drop grant_cond + the emit/clear block; the dev fixture state now (correctly) produces no notice - TUI: keep the turn-start clear of credits.grant_spent as back-compat for older backends that still emit the key - Desktop: drop the demo step and stale comment references - Docs/config comments: remove grant-spent from credits_notices text - Tests updated: policy/cold-start now assert the key never fires Usage bands, depleted, and restored notices are unchanged; /usage still reports the full balance breakdown.
Contributor
૮ >ﻌ< ა ci reviewran on e533d69 ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence upload failed. Failed to upload diff-665a0833239e-onboarding-overlay-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-665a0833239e-onboarding-overlay-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso) |
alt-glitch
added
type/bug
Collaborator
@rob-maron Tagging you on this credits-notice item as the soft maintainer (follow-up to #43669). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the "Grant spent · $X top-up left" credits notice from every surface — it camped in the CLI/TUI status bar and desktop toasts for any subscription user holding top-up funds, with no action for the user to take (the account keeps working off top-up).
Changes
agent/credits_tracker.py: dropgrant_cond+ thecredits.grant_spentemit/clear block; thegrant_exhausteddev fixture now correctly produces no noticeui-tui/src/app/turnController.ts: keep the turn-start clear ofcredits.grant_spentas back-compat for older backends that still emit the keyapps/desktop: remove the demo step and stale comment references; retest split-meta/accent/native-notification paths on surviving noticeshermes_cli/config.py+website/docs/user-guide/configuration.md: drop grant-spent from thedisplay.credits_noticesdescriptionsUsage bands (50/75/90), depleted, and restored notices are unchanged;
/usagestill reports the full balance breakdown.Validation
Infographic