Repository navigation
fix(discord): reject empty outbound messages #73449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
zyz619963502zyz
wants to merge
4
commits into
NousResearch:main
from
zyz619963502zyz:fix/discord-empty-message
Closed
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6ae668b
fix(discord): reject empty outbound messages
zyz619963502zyz 60dfc68
test(discord): cover empty final reply backfill state
zyz619963502zyz 59c84e3
fix(discord): preserve backfill state for empty replies
zyz619963502zyz 24a3fcc
Merge branch 'main' into fix/discord-empty-message
zyz619963502zyz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This return bypasses the existing failure bookkeeping in
send()(_record_discord_responseis called by the outer exception path). Please record this failed result with the samereply_to,content, andfinalarguments before returning, so missed-message backfill retains the failure state for an empty final reply.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in
24a3fccafter merging current main1789e06. The empty-content path now records the failedSendResultthrough_record_discord_responsewith the samereply_to,content, andfinalvalues before returning. The regression exercises the real backfill database for a whitespace-only final reply and verifies it remainsfailed/not responded while no Discord I/O occurs.Validation:
test_discord*.py: 203 passed, 11 environment failures also reproduced on the unmodified baseline (missingaiohttp/ incomplete Discord mock); baseline was 202 passed plus this regression failurecompileall, andgit diff --check: passedThe branch is now current with
main, mergeable, and the final diff is limited to these two files (+55/-0).