fix(desktop): bind submits to activated session - #73282
Closed
CryptoDombili wants to merge 1 commit into
Closed
CryptoDombili wants to merge 1 commit into
CryptoDombili wants to merge 1 commit into
Conversation
Prevent prompt submissions from using stale runtime session IDs during asynchronous session switches and add regression coverage.
Collaborator
|
Thanks for the focused investigation and regression coverage. This automated hermes-sweeper review found that current main already protects this routing path.
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents Desktop prompt submissions from being routed to a stale runtime session during asynchronous session switches.
The submit path now waits for the latest
session.activateorsession.resumeacknowledgement and re-reads the active runtime session immediately beforeprompt.submit.Related issue
Fixes #72971
Related to #66661, but this PR addresses the stale activation and submit-routing path rather than rejected-submit composer restoration.
Type of change
Changes made
prompt.submitHow to test
Checklist