Skip to content

fix(tests): preserve config module identity in backup tests #73272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frizikk wants to merge 1 commit into from
Closed

fix(tests): preserve config module identity in backup tests #73272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions tests/hermes_cli/test_backup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2296,10 +2296,9 @@ def hermes_home(self, tmp_path, monkeypatch):
monkeypatch.setenv("HERMES_HOME", str(root))
# Make Path.home() point at tmp_path for anything that uses it
monkeypatch.setattr(Path, "home", lambda: tmp_path)
# Bust caches for hermes_cli.config + hermes_constants so they pick up HERMES_HOME
for mod in list(__import__("sys").modules.keys()):
if mod.startswith("hermes_cli.config") or mod == "hermes_constants":
del __import__("sys").modules[mod]
# Config reads resolve HERMES_HOME dynamically and their caches are
# keyed by config path. Do not remove shared modules from sys.modules:
# other test modules may retain imports from the existing module object.
return root

@staticmethod
Expand All @@ -2309,10 +2308,6 @@ def _set_mode(hermes_home, value):
"_config_version": 22,
"updates": {"pre_update_backup": value},
}))
import sys as _sys
for mod in list(_sys.modules.keys()):
if mod.startswith("hermes_cli.config"):
del _sys.modules[mod]

@staticmethod
def _zips(hermes_home):
Expand Down
Loading