fix(gateway): set empty dict instead of None for request_overrides - #7320
Closed
joesaiw1208-stack wants to merge 1 commit into
Closed
fix(gateway): set empty dict instead of None for request_overrides#7320joesaiw1208-stack wants to merge 1 commit into
joesaiw1208-stack wants to merge 1 commit into
Conversation
…en service_tier is unset
When service_tier is empty, _build_turn_route() was setting
request_overrides to None, which would later override the dict
initialized in AIAgent.__init__. This caused an AttributeError
when code tried to call .get() on None in run_agent.py line 5522.
The fix is to use {} instead of None, consistent with how
request_overrides is initialized in AIAgent.__init__:
self.request_overrides = dict(request_overrides or {})
Collaborator
Contributor
|
Automated hermes-sweeper review: this PR's requested fix is already implemented on current Evidence:
Thanks for the report and patch. This overlaps with the related competing fix mentioned in the thread (#7281 / #7259), so the behavioral guarantee is now covered on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When service_tier is empty, _build_turn_route() was setting request_overrides to None, which would later override the dict initialized in AIAgent.init. This caused an AttributeError when code tried to call .get() on None in run_agent.py line 5522.
The fix is to use {} instead of None, consistent with how request_overrides is initialized in AIAgent.init.