fix(mcp): catch RuntimeError when cancelling tasks during /exit (#60197) - #73190
Closed
JonthanaHanh wants to merge 1 commit into
Closed
fix(mcp): catch RuntimeError when cancelling tasks during /exit (#60197)#73190JonthanaHanh wants to merge 1 commit into
JonthanaHanh wants to merge 1 commit into
Conversation
…Research#60197) When /exit closes the asyncio event loop, MCP server tasks still running in _wait_for_reconnect_or_shutdown call t.cancel() which invokes call_soon() on the closed loop, raising RuntimeError. Fix: move t.cancel() inside the try block so RuntimeError is caught. Applied to both locations (keepalive loop and reconnect handler).
alt-glitch
added
type/bug
Collaborator
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60197. During /exit, event loop closes before MCP tasks finish. t.cancel() calls call_soon() on closed loop raising RuntimeError. Moved t.cancel() inside try block to catch RuntimeError. Applied to both locations. 743 MCP tests passed.