fix: move plugin load before backend resolve in web_extract - #73183
fix: move plugin load before backend resolve in web_extract#73183kyan001 wants to merge 1 commit into
Conversation
Extract should load plugins before checking registry, same as search. Now custom extract plugins can't be found on cold start.
|
Thanks for the focused fix. The current Problems
Suggested changes
Automated hermes-sweeper review. |
SummaryOne PR addresses #73192. #73183 moves plugin loading ahead of extract-backend resolution, directly correcting the reported cold-start registry lookup failure. Related pull requests
Suggested consolidationKeep #73183 open with the concrete salvage path identified by the maintainer-bot review: add the cold-start custom-provider regression test that fails under the current ordering and passes with this reorder. No competing or duplicate PRs are present. Complex graphflowchart LR
classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
classDef best stroke-width:3px,stroke:#b45309
classDef target stroke-width:3px,stroke:#4338ca
I73192(["issue #73192 (open)"])
P73183["PR #73183 (open)"]
P73183 -->|best fix| I73192
class I73192 open
class P73183 open
class P73183 best
class P73183 target
click I73192 "https://github.com/NousResearch/hermes-agent/issues/73192"
click P73183 "https://github.com/NousResearch/hermes-agent/pull/73183"
Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label). Cross-PR triage: Reviewed 1 pull request and 1 issue in this complex. Each diff was read against this issue; Assessment working set: <1 kB of PR diffs, 4 kB of issue/PR text, 2 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch. |
Extract should load plugins before checking registry, same as search. Now custom extract plugins can't be found on cold start.
What does this PR do?
Fix init order in
web_extract_tool: load plugins before checking registry, matching the pattern already used byweb_search_tool. Without this, custom extract plugins can't be found on cold start.Related Issue
Fixes #73192
Changes Made
tools/web_tools.py: moved_ensure_web_plugins_loaded()before_get_extract_backend()inweb_extract_toolHow to Test
web.extract_backend: my-extractor)web_extract(urls=[...])as the first web operation