fix(discord): prevent duplicate threads on create_thread exception (#73032) - #73092
Open
JonthanaHanh wants to merge 1 commit into
Open
fix(discord): prevent duplicate threads on create_thread exception (#73032)#73092JonthanaHanh wants to merge 1 commit into
JonthanaHanh wants to merge 1 commit into
Conversation
…ousResearch#73032) When message.create_thread() succeeds on Discord's side but raises an exception (timeout, connection reset), the fallback path sends a seed message and creates a second thread. Both threads remain active and can receive separate agent turns, causing duplicate responses. Fix: after create_thread() raises, check message.thread for an existing thread before falling back to the seed message path. If the thread was already created (API succeeded but response was lost), reuse it instead of creating a duplicate.
10 tasks
alt-glitch
added
type/bug
Contributor
|
Thanks for addressing the ambiguous-success path. The underlying defect remains on current main: after a direct-create exception, Problems
Suggested changes
Automated hermes-sweeper review. |
teknium1
added
sweeper:risk-session-state
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73032. When message.create_thread() succeeds on Discord but raises (timeout/connection reset), fallback path creates a second thread. Added check for message.thread after exception to reuse existing thread instead of creating duplicate. 30 auto-thread tests passed, 1 flaky (pre-existing).