fix(desktop): stop tip-wrapping obvious chrome - #73062
Merged
Merged
Conversation
Drop the blanket "every icon* button needs a Tip" rule — it produced tautological kebab tips like "Actions for <row title>". Menu triggers keep aria-label; tips stay for unlabeled discovery chrome and keybind hints.
Remove the ActionsMenu tooltip prop and Tip wrappers on session, project, workspace, panel, and credential ⋯ menus. aria-label stays for a11y; drop the unused credentialActions string.
Flip the #67500 structure tests that required tooltip-trigger on menu kebabs; keep coverage that the menus still open on click.
Collaborator
Author
|
@ethernet8023 — heads up: this revises the DESIGN tip rule from #65204 (every |
alt-glitch
added
type/bug
Contributor
૮ >ﻌ< ა ci reviewran on 015353d ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence upload failed. Failed to upload diff-665a0833239e-onboarding-overlay-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-665a0833239e-onboarding-overlay-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso) |
Extend the tip rule past kebabs — no tip on dismiss X, and no tips that only paraphrase a visible label or say "click to…".
Drop tips on dialog/overlay/find-bar/review/master-detail close buttons. Stop tip-wrapping connection/gateway/timer/context/cron/webhook chrome that already names itself on screen; keep tip only when there's a real gateway reason. Drop the titlebar swap paraphrase.
Use short static labels (Session actions / Actions) instead of Actions for <name>. Trim toast fallback, settings echoes, YOLO click lectures, and fat gateway/appearance/notifications intros.
OutThisLife
changed the title
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
fix(desktop): stop tip-wrapping kebab menu triggers
33hodl
pushed a commit
to 33hodl/hermes-agent
that referenced
this pull request
Aug 12, 2026
fix(desktop): stop tip-wrapping kebab menu triggers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop tip tax got out of hand. A DESIGN rule that every icon button needed a
<Tip>produced tautological hover text on kebabs, close buttons, and statusbar chrome. Tips should only teach something hover can't already see.Removed tips
Kebab / menu triggers
"Actions for ${title}""Project actions""Project actions""Actions"(or caller label)"Credential actions"Close / dismiss X
"Close""Close settings"/ etc."Close""Close"Statusbar / titlebar lectures
"Connected … · click to manage""Hermes inference gateway status""Current turn elapsed"/"Runtime session elapsed""Open context usage breakdown""Open cron jobs"/"Open webhooks""Swap sidebar sides"Aria + copy
aria-labels shortened to"Session actions"/"Actions"(no"Actions for <name>")"The response is ready."→ empty (body already has response text when present)credentialActionsi18n string removedActionsMenu/SessionActionsMenutooltipprop removedLeft alone (still useful)
Keybind hints, truncated paths / cwd tip, handoff platform badge, appearance icon grid, load-more / new-worktree / share import-export, icon-only titlebar/statusbar (Command Center, terminal), gateway tip when there's a real status reason, layout-editor tip (⌘-click reset).
Test plan
npx vitest rundialog / sidebar / panel / toolset-config tests