Skip to content

fix: replace assert with runtime guard in session recovery #73050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JonthanaHanh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace assert with runtime guard in session recovery #73050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion hermes_cli/session_recovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,7 +1238,10 @@ def recover_session_database(
output_path=output_path,
work_dir=work_dir,
)
assert output is not None
if output is None:

@teknium1 teknium1 Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a regression test that invokes this path under python -O with output_path=None and asserts SessionRecoverySafetyError; that directly protects the optimization-sensitive behavior this guard replaces.

raise SessionRecoverySafetyError(
"output_path is required for session recovery"
)
disk_space = _disk_space_preflight(source, work_root, output.parent)

temp_dir, snapshot_source, inspection = _snapshot_and_inspect(source, work_root)
Expand Down
Loading