Skip to content

feat(desktop): brand icons on links to known domains - #73047

Merged
OutThisLife merged 3 commits into
mainfrom
bb/link-brand-icons
Jul 28, 2026
Merged

feat(desktop): brand icons on links to known domains#73047
OutThisLife merged 3 commits into
mainfrom
bb/link-brand-icons

Conversation

@OutThisLife

@OutThisLife OutThisLife commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Links to sites we recognize now lead with the site's brand mark, so a GitHub PR link reads as a GitHub link at a glance instead of another blue chip. PrettyLink covers every markdown link, autolink, and linkified tool output in chat; the artifacts pane uses the same lookup in place of its generic chain glyph.

Hosts resolve by walking the hostname's suffixes, so gist.github.com inherits GitHub's mark without needing its own entry, while a more specific entry like docs.google.com still beats the general google.com one. Unknown hosts render exactly as before — no placeholder, no reserved slot.

The table covers ~170 hosts from Simple Icons, already a dependency here. Slack, LinkedIn, OpenAI, Amazon, and CodePen are deliberately absent: Simple Icons removed them at the owners' request, so those fall through to no glyph rather than a lookalike.

With a mark now carrying the recognition, the chip itself got quieter — links sit in the theme's primary color at body weight, and the tinted fill only appears on hover.

Three details worth flagging for review:

  • Glyphs paint in currentColor, not the brand hex. Several brand colors (GitHub's near-black, Unity's white) disappear against one theme or the other.
  • title="" on the icon is load-bearing. Simple Icons always renders a <title> defaulting to the brand name, which lands in the anchor's textContent and accessible name — without it a PR link reads "GitHub#123". There's a test on that.
  • The font-weight override lives on .link-chip, not the call sites. @tailwindcss/typography sets prose a { font-weight: 500 }, which outranks a utility class on the anchor, so stripping font-semibold from each call site alone did nothing.

Test plan

  • tsc -p apps/desktop --noEmit clean
  • eslint clean on all touched files
  • Full desktop suite green — 3504 passed, 3 skipped
  • Resolver contract covered: suffix walk, longest match, www./case normalization, no bare-TLD match
  • Render-level: known host emits an <svg>, unknown host emits none, glyph stays out of the link's accessible name
  • Checked live over HMR across prose, lists, blockquotes, nested bold/italic, back-to-back links, wrapped long URLs, and unknown-host controls

@alt-glitch alt-glitch added type/feature New feature or request comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have labels Jul 28, 2026
A lookup table of ~170 hosts plus a resolver that walks the hostname's
suffixes, so subdomains inherit their parent's mark (gist.github.com) while
a more specific entry (docs.google.com) still wins over the general one.
PrettyLink leads with the site's mark, so a GitHub PR link reads as a GitHub
link at a glance. The artifacts pane uses the same lookup in place of its
generic chain glyph; unknown hosts render as before.
@OutThisLife
OutThisLife force-pushed the bb/link-brand-icons branch 2 times, most recently from 17cf0e2 to 23459c0 Compare July 28, 2026 02:26
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on df7352a

ℹ️ Info

Desktop E2E visual evidence · View test artifacts · View job

2 visual diffs.

inline evidence upload failed.

Failed to upload diff-3d0b55a29cbf-boot-ready-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-3d0b55a29cbf-boot-ready-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso)

The resting chip fill and the bold weight both fought the brand mark for
attention. Links now sit in the theme's primary color at body weight, and
the tint fades in on hover.

Weight is overridden on .link-chip itself: `@tailwindcss/typography` sets
`prose a { font-weight: 500 }`, which outranks a utility class on the anchor,
so the per-call-site classes could never win.
@OutThisLife OutThisLife reopened this Jul 28, 2026
@OutThisLife
OutThisLife merged commit c1964f9 into main Jul 28, 2026
34 checks passed
@OutThisLife
OutThisLife deleted the bb/link-brand-icons branch July 28, 2026 03:16
randlee pushed a commit to randlee/hermes-agent that referenced this pull request Aug 11, 2026
…-icons

feat(desktop): brand icons on links to known domains
33hodl pushed a commit to 33hodl/hermes-agent that referenced this pull request Aug 12, 2026
…-icons

feat(desktop): brand icons on links to known domains
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants