Skip to content

fix(deps): resolve npm audit vulnerabilities - #72878

Open
LironTTG wants to merge 1 commit into
NousResearch:mainfrom
LironTTG:fix/npm-audit-vulnerabilities
Open

LironTTG wants to merge 1 commit into
NousResearch:mainfrom
LironTTG:fix/npm-audit-vulnerabilities

Conversation

@LironTTG

Copy link
Copy Markdown

Summary

  • updates npm dependency resolutions to clear audit findings, including patched tar-related transitive packages
  • pins desktop/web React Router DOM resolution and overrides react-router to the patched version
  • adds missing desktop use-effect-event dependency exposed by the regenerated tree

Verification

  • npm audit: found 0 vulnerabilities
  • security_scan.sh npm section: critical:0 high:0 moderate:0 low:0
  • npm run typecheck --workspace apps/desktop
  • npm run typecheck --workspace web
  • npm run build --workspace web

@LironTTG
LironTTG requested a review from a team July 27, 2026 19:54
@alt-glitch alt-glitch added type/security Security vulnerability or hardening P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) comp/dashboard Web dashboard / control panel UI (dashboard/, landing) labels Jul 27, 2026

@teknium1 teknium1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the audit findings. Two blockers need correction before this dependency update is safe to salvage.

Problems

  • package.json:49 overrides every react-router resolution to root 8.3.0, while this PR keeps react-router-dom@7.18.1. The published react-router-dom@7.18.1 manifest requires react-router exactly 7.18.1; published react-router@8.3.0 also requires Node >=22.22.0, while the root supports Node >=20.0.0 (package.json:46).
  • The regenerated package-lock.json removes Linux, Windows, and Darwin @esbuild/* entries. Current main commit 745d1383 restored these cross-platform entries specifically because pruning them breaks Linux/Windows installs.

Suggested changes

  • Keep React Router package versions compatible, rather than forcing react-router@8.3.0 beneath react-router-dom@7.18.1.
  • Rebuild the remediation from current main's lockfile and preserve the cross-platform esbuild entries restored in 745d1383.

Automated hermes-sweeper review.

Comment thread package.json
"postcss": "^8.5.23",
"shell-quote": "^1.10.0",
"brace-expansion": "^5.0.8",
"react-router": "$react-router"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-router-dom@7.18.1 depends on react-router exactly 7.18.1, but this override forces its dependency to 8.3.0. The forced package also requires Node >=22.22.0 while this repository supports Node >=20. Please retain a v7-compatible resolution or make a complete, separately validated v8 migration.

@teknium1 teknium1 added sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-platform-windows Sweeper risk: may break or behave differently on native Windows sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/dashboard Web dashboard / control panel UI (dashboard/, landing) comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-platform-windows Sweeper risk: may break or behave differently on native Windows sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data type/security Security vulnerability or hardening

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants