Conversation
teknium1
reviewed
Jul 30, 2026
teknium1
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for addressing the audit findings. Two blockers need correction before this dependency update is safe to salvage.
Problems
package.json:49overrides everyreact-routerresolution to root8.3.0, while this PR keepsreact-router-dom@7.18.1. The publishedreact-router-dom@7.18.1manifest requiresreact-routerexactly7.18.1; publishedreact-router@8.3.0also requires Node>=22.22.0, while the root supports Node>=20.0.0(package.json:46).- The regenerated
package-lock.jsonremoves Linux, Windows, and Darwin@esbuild/*entries. Current main commit745d1383restored these cross-platform entries specifically because pruning them breaks Linux/Windows installs.
Suggested changes
- Keep React Router package versions compatible, rather than forcing
react-router@8.3.0beneathreact-router-dom@7.18.1. - Rebuild the remediation from current main's lockfile and preserve the cross-platform esbuild entries restored in
745d1383.
Automated hermes-sweeper review.
| "postcss": "^8.5.23", | ||
| "shell-quote": "^1.10.0", | ||
| "brace-expansion": "^5.0.8", | ||
| "react-router": "$react-router" |
Collaborator
There was a problem hiding this comment.
react-router-dom@7.18.1 depends on react-router exactly 7.18.1, but this override forces its dependency to 8.3.0. The forced package also requires Node >=22.22.0 while this repository supports Node >=20. Please retain a v7-compatible resolution or make a complete, separately validated v8 migration.
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification