perf(dashboard): lazy-load routes + split vendors; polish session-list placeholders - #72294
Merged
Conversation
The production dashboard build packed almost every page plus xterm/three/ plot into one large JS chunk, which trips Vite's 500kB warning and slows first paint even when the user only opens Sessions/Config. - Lazy-load route pages in App.tsx behind Suspense - Defer mounting the persistent embedded chat host (and xterm) until the first /chat visit, while keeping the sticky PTY latch afterward - Add rolldown vendor codeSplitting groups (react, xterm, three, plot, motion, ui) and raise chunkSizeWarningLimit modestly to 600kB Addresses #25912 (partial: route lazy-load + vendor splits + fallbacks; not yet CI bundle analysis or documented entry budget). Verified locally: npm run typecheck, npm run test (97), npm run build with separate page/vendor chunks.
…n lists Sessions that die before title generation (or predate model tracking) rendered as 'Untitled · unknown · 0 msgs' — two placeholders stacked in one row reads as breakage to Hermes Cloud users. Now: - Session rows omit the model segment entirely when the store has no model (no more 'unknown' + dangling separator). - The Overview 'Recent Sessions' card falls back to the message preview as the row label (italic, same treatment as the History list) instead of a bare 'Untitled', and skips the duplicate preview paragraph when the preview IS the label.
alt-glitch
added
type/perf
Contributor
૮ >ﻌ< ა ci reviewran on 97a41f2 ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence upload failed. Failed to upload diff-665a0833239e-onboarding-overlay-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-665a0833239e-onboarding-overlay-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso) |
This was referenced Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dashboard load-time and session-list polish — the two follow-ups deferred from the #72234 QA pass. First paint no longer downloads the entire 2 MB admin bundle (xterm/terminal included), and session lists stop rendering "Untitled · unknown" placeholder stacks.
Salvages #72119 by @erick713006 (route-level code splitting, fixes #25912), cherry-picked with authorship preserved.
Changes
perf: lazy-load routes + split heavy vendors (salvaged from #72119, @erick713006)
web/src/App.tsx: all page imports converted toReact.lazy,<Routes>wrapped in<Suspense>with a shared spinner fallback; the persistent embedded-chat host (and its xterm chunk) is deferred until the first/chatvisit, sticky afterward so the PTY still survives tab switches (latchChatActivation).web/vite.config.ts: rolldowncodeSplittinggroups for react/xterm/three/plot/motion/ui/vendor;chunkSizeWarningLimit: 600so true regressions still warn. Follow-up commit normalizes the CRLF line endings the cherry-pick introduced.fix: session lists render placeholders gracefully
unknownwith a dangling separator.Validation
webnpm run check (typecheck + vitest + eslint)Infographic