feat(cli,desktop): persistent /goal indicator in status bar and above composer (salvage of #63527) - #72244
Merged
Conversation
Contributor
૮ >ﻌ< ა ci reviewran on bf8b78d ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence upload failed. Failed to upload diff-665a0833239e-onboarding-overlay-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-665a0833239e-onboarding-overlay-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso) |
alt-glitch
added
type/feature
Collaborator
…locale copy Follow-ups on the salvaged goal-status display (#63527): - Seed the goal store from the /goal dispatch notice ("⊙ Goal set …") and from /goal status|pause|resume|clear exec output in slash.ts. The backend only emits status.update kind:"goal" after the first turn's post-turn judge, so without this the indicator stayed empty while the kickoff turn ran (sweeper review finding on #63527). - Add the missing ja / zh-hant statusStack goal copy — desktop ships four locales, not two (sweeper review finding on #55651). - Add a component-level vitest for the composer goal indicator rendering from store states: none / active / paused / detail line / other-session. Co-authored-by: HaisamAbbas <95044189+HaisamAbbas@users.noreply.github.com> Assisted-by: Claude Fable 5 via Hermes Agent
Append a "⊙ goal 3/20" segment (turns used / turn budget) to the CLI status bar whenever a standing /goal is active. Mirrors the desktop composer goal indicator: active-goal-only — paused/done goals stay out of the bar since they already print their own glyph lines in-thread. - Snapshot: goal_active / goal_turns_used / goal_max_turns from the cached GoalManager (in-memory attribute read, no DB hit per repaint). - Rendered in all three width tiers of both _build_status_bar_text and _get_status_bar_fragments, and it respects the /statusbar toggle for free (the toggle gates _get_status_bar_fragments as a whole). - Tests: segment composition, active-only contract, all width tiers. Status-bar goal indicator concept from #43020. Co-authored-by: Akshan Krithick <akshankrithick305@gmail.com> Assisted-by: Claude Fable 5 via Hermes Agent
teknium1
force-pushed
the
ux/goal-statusbar
branch
from
July 26, 2026 23:20
cbe33fd to
bf8b78d
Compare
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An active
/goalis now visible at a glance instead of only in the turn-by-turn scrollback: agoal 3/20segment in the CLI status bar, and a progress row above the Desktop composer showing active / paused / achieved state. Salvage of #63527 by @wjj1872744570-source, extended with the CLI half and locale coverage.ChatGPT Work shows a persistent goal progress row above its composer; Codex CLI keeps goal state in its status line. Hermes had
/goalbut no persistent indicator on any surface — once the glyph line scrolled away, the only way to check was/goal status.How it works
Goal state stays backend-authoritative per
apps/desktop/AGENTS.md— the renderer subscribes to it through the existing goal event path rather than polling, and the store treats it as a cache of backend truth. Display-only: no new gateway RPCs, no controls that don't already have a backend verb. The CLI segment renders inside the existing status-bar composer and honors/statusbar.Changes
apps/desktop/src/store/goals.ts— goal state store + hydration on/goalset and controlsapps/desktop/src/store/composer-status.ts— progress row above the composerapps/desktop/src/i18n/{en,zh,zh-hant}.ts— full locale copycli.py—goal N/Mstatus-bar segment, active-goal-onlytests/cli/test_cli_status_bar_goal.py(8 tests) +apps/desktop/src/store/goals.test.ts(5 tests)Validation
scripts/run_tests.sh tests/cli/test_cli_status_bar_goal.pynpx vitest run src/store/goals.test.tsSupersedes the 4-PR cluster: #63527 (base, credited), #55651, #48285, #43020 — to be closed with credit after merge.
Infographic