test(gateway): isolate runtime PID identity fallback - #72237
Conversation
|
Thanks for tightening this regression coverage. On current main, This is an automated hermes-sweeper review. |
Stub the command-line probe in the unreadable-inspection fallback test so a coincidental live PID cannot make it depend on the host process table. Add a separate case that pins rejection of an unrelated live process.
a8bae3f to
287cf94
Compare
|
Closing this PR because its documented purpose is a test-only isolation change discovered while refocusing closed issue #70016. The PR body does not identify an independent open issue or current product/security defect beyond that closed target, and #70016 is closed (GitHub provides no state reason). Recommendation: close rather than merge or redo as-is. The branch is left intact. |
Summary
Why
The fallback test previously supplied a live PID without controlling its
command line. A coincidental host process could therefore make the test depend
on external process state. This test-only change was discovered while
refocusing closed PR #70016 and is intentionally published separately from the
security implementation.
Validation
tests/hermes_cli/test_gateway_runtime_health.py: 8 passedmainmerge-tree and diff checks passThe account owner loosely reviews Codex actions and receives the usual GitHub
notifications.
Agent Disclosure