fix(desktop): add Nerd Font fallbacks to terminal font stacks - #72153
Open
adurham wants to merge 1 commit into
Open
fix(desktop): add Nerd Font fallbacks to terminal font stacks#72153adurham wants to merge 1 commit into
adurham wants to merge 1 commit into
Conversation
adurham
added a commit
to adurham/hermes-agent
that referenced
this pull request
Jul 26, 2026
…tems Documents outcomes for the 6 desktop-category Bucket A items: Submitted (4): - PR NousResearch#72151 -- RAF-throttle blank transcript on session switch - PR NousResearch#72152 -- profile deletion zombie backend + cross-window rail staleness - PR NousResearch#72153 -- Nerd Font terminal fallback - PR NousResearch#72155 -- desktop model picker hiding Anthropic Deprioritized, needs hand-reconciliation (3): drag-to-reorder, workspace tab close button, queued composer wrong-session delivery. All three rejected 1+ files on git apply --check with real semantic drift (not line-offset noise) against the fast-churning desktop session/composer code. Flagged for revisit rather than force-applying a stale patch. The profile-deletion and model-picker items both got real scrutiny beyond "does it apply cleanly": profile-deletion required two rounds of external consult after search-first turned up 2 already-merged PRs on the same headline symptom -- verified directly (not assumed) that this fix's two pieces are genuinely non-overlapping gaps, not stale duplicates. Model picker's fix was confirmed to extend an already-established upstream credential-detection pattern rather than introduce new CC-mimicry plumbing, addressing the specific caution flagged in the original audit. Saved verified patches to .upstream-candidates/ for reference. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
alt-glitch
added
type/bug
Contributor
|
Thanks for the focused Desktop fix. Current main still uses the no-Nerd-Font stack in both xterm.js constructors: A search of Automated hermes-sweeper review. |
teknium1
added
sweeper:risk-compatibility
adurham
added a commit
to adurham/hermes-agent
that referenced
this pull request
Jul 31, 2026
…s on all 7 PRs Documents the real external engagement on the 7 upstream PRs filed 2026-07-26, and the 3 substantive follow-up fixes pushed in response: - NousResearch#72054 closed as superseded, but merged anyway via NousResearch#74139 (contributor CrowLoki's reconciliation with NousResearch#62026, credited via Co-authored-by). - NousResearch#72087, NousResearch#72151, NousResearch#72152, NousResearch#72153, NousResearch#72155, NousResearch#72164 all reviewed by the repo's automated sweeper -- keep_open/high on all 6. - Fixed NousResearch#72087 (payload-proportional test assertions, catching a future allowlist-regression risk flagged by both the sweeper and an independent contributor who measured it precisely on their own fork). - Fixed NousResearch#72152 (extracted ProfileRail's focus/visibilitychange wiring into a tested hook, matching the directory's own established use-profile-prewarm.ts pattern). - Rebased NousResearch#72155 past a real merge conflict (an unrelated upstream test-pruning pass removed 3 tests my diff's context touched). All fixes verified by simulating the exact regression each review was warning about and confirming the new tests catch it, then restoring the real fix. Also noted a real environment issue found this session: the `upstream` remote's SSH URL intermittently fails to connect from this network; a one-off HTTPS fetch into a separate ref works around it without touching the configured remote. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Retargeted after an upstream refactor (since this PR was originally filed) introduced user-configurable terminal fonts: the two hardcoded font-family strings this PR originally patched no longer exist as such -- both call sites now derive their font family from resolveTerminalFontFamily(), which falls back to the single DEFAULT_TERMINAL_FONT_FAMILY constant in terminal-font.ts when the user hasn't configured a custom font. The underlying bug is unchanged and still real: DEFAULT_TERMINAL_FONT_FAMILY had no Nerd Font fallback, so an unconfigured install renders powerline separators and Codicon-range glyphs some CLI output emits as tofu boxes. Since the fix is now centralized in one constant instead of two call sites, the change is actually simpler than the original PR. Existing tests reference DEFAULT_TERMINAL_FONT_FAMILY symbolically (not as a hardcoded string literal), so they needed no changes and still pass unmodified -- confirms the fix is contained to the one constant. Tests: terminal-font.test.ts 8/8 passed. Broader regression sweep of the terminal directory (use-agent-terminal, use-terminal-session, use-terminal-font, persistent, rail, links, revive-buffer): 9 files, 61 tests passed, 0 regressions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
adurham
force-pushed
the
upstream-pr/desktop-nerd-font-terminal
branch
from
August 2, 2026 16:54
02ea909 to
fa59e5d
Compare
Contributor
Author
|
Rebased and retargeted -- an upstream refactor since this PR was filed introduced user-configurable terminal fonts ( Existing tests reference the constant symbolically rather than as a string literal, so they needed no changes and pass as-is (8/8). Ran the full terminal directory as a regression check given the refactor: 9 files, 61 tests, 0 failures. |
adurham
added a commit
to adurham/hermes-agent
that referenced
this pull request
Aug 2, 2026
…Research#72153 both hit real upstream refactors Documents rebasing both PRs onto main a few days after the first fix round, finding both had real merge conflicts caused by unrelated upstream work independently touching the exact code they target: - NousResearch#72087: upstream's own NousResearch#73298 refactor extracted a shared _wire_message_shadow() helper and independently reintroduced the same underscore-mismatch bug this PR describes (verified 4.04x overcount on unpatched main). Retargeted the fix into the new shared helper. - NousResearch#72153: upstream landed a user-configurable terminal font feature that replaced the two hardcoded strings this PR touched. The underlying bug was still real against the new default constant; fix collapsed to a single-constant change. All 6 open PRs confirmed mergeable as of today. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
adurham
added a commit
to adurham/hermes-agent
that referenced
this pull request
Aug 4, 2026
Post-merge audit of FORK.md against upstream v2026.8.3 found two fork changes the merge silently dropped: - terminal-font: Nerd Font fallbacks in DEFAULT_TERMINAL_FONT_FAMILY. Upstream's font-picker refactor (terminal-font.ts) replaced the two hardcoded fontFamily strings the fork had patched (FORK.md 2026-07-22, upstream PR NousResearch#72153); the merge took upstream's file verbatim, reviving the tofu-box bug. Re-applied as the one-constant form. - config: agent.pin_anthropic_token default (FORK.md 2026-07-25). Upstream's config split (config.py -> config_defaults.py) dropped the fork's key; the reader in agent/anthropic_adapter.py fails safe, but the documented default belongs in DEFAULT_CONFIG. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes terminal glyphs rendering as tofu boxes in Hermes Desktop's
xterm.js terminals when the user's shell prompt assumes Nerd Font glyphs.
Root Cause
Both xterm.js terminal instances (interactive PTY terminal and the
read-only agent-output terminal) hardcode a font stack with no Nerd Font
fallback:
"'JetBrains Mono', 'Cascadia Code', 'SF Mono', Menlo, Consolas, monospace".Shell prompts that assume Nerd Font glyphs (powerline separators,
starship/oh-my-posh icons) render as tofu boxes instead of falling back
to an installed Nerd Font — unlike native terminals (kitty, etc.), whose
OS-level font fallback picks up an installed Nerd Font automatically.
xterm.js uses its own font-family CSS property rather than OS fallback,
so the fallback chain must be explicit.
Changes Made
Add
Hack Nerd Font Mono/FiraCode Nerd Font Mono/Symbols Nerd Font Monoto the fallback chain afterJetBrains Monoin both:apps/desktop/src/app/right-sidebar/terminal/use-agent-terminal.tsapps/desktop/src/app/right-sidebar/terminal/use-terminal-session.tsRelated Issue
No existing issue found (searched
gh search issuesfor "tofu boxterminal font", "Nerd Font desktop terminal", "powerline glyph missing
desktop" — no hits).
Type of Change
How to Test
powerlevel10k with powerline separators).
the system default.
Nerd Fonts are installed.
vitest run src/app/right-sidebar/terminal— 25 passed, 0 failed (noregressions; a font-family string constant has no meaningful unit test
to add).
Checklist