fix(nix): update Electron headers sha256 hash to fix hermes-desktop nix build (#72095) - #72121
fix(nix): update Electron headers sha256 hash to fix hermes-desktop nix build (#72095)#72121kyssta-exe wants to merge 1 commit into
Conversation
…ix build (NousResearch#72095) The pinned sha256 for the Electron node-gyp headers tarball was stale, causing Nix fixed-output derivation hash mismatches when building hermes-desktop. Updated to the current correct hash reported by . Closes NousResearch#72095
teknium1
left a comment
There was a problem hiding this comment.
Thanks for isolating the Electron-header failure.
Problems
nix/desktop.nix:33-34still pairs a URL derived from${electron.version}with one fixed SHA. Replacing that SHA with the 41.9.1 value fixes only that version; it preserves the mismatch class whenever Electron changes.- The PR does not change
flake.lock, and currentmainhas the samenix/desktop.nixblob as the PR base. The linked #61443/#53202 discussion records that the repository lock resolves Electron 41.0.2 while the proposed hash is for 41.9.1, so this can break the default locked build rather than support both inputs.
Suggested changes
- Remove the manual
fetchurl/tar extraction and use${electron.headers}asnode-gyp's--nodedir, as in the durable approach documented on #61443. - Verify both the pinned and overridden Electron inputs with
nix build .#desktop.
Automated hermes-sweeper review.
| electronHeaders = pkgs.fetchurl { | ||
| url = "https://artifacts.electronjs.org/headers/dist/v${electron.version}/node-v${electron.version}-headers.tar.gz"; | ||
| sha256 = "sha256-zi/QMwRZ0+FwE9XTE+DiSIeJXAwxmLKEaBWD5W3pMOI="; | ||
| sha256 = "sha256-zOl8rx6woWh7aeRUOlkTMviKc/EAQQX6nr/MxAx1ZPI="; |
There was a problem hiding this comment.
This hash is specific to the reported Electron 41.9.1 archive, while line 33 still derives the URL from arbitrary ${electron.version}. Please remove the independent fetch/hash and point node-gyp at ${electron.headers} instead; otherwise any differing or future Electron version can desynchronize this pair again.
|
Closing this PR because it is not mergeable: it has merge conflicts with |
Problem
nix/desktop.nixpins a stalesha256for the Electron node-gyp headers tarball. Buildinghermes-desktopwith Nix fails with:Fix
Updated the pinned hash to the current correct value (the
got:hash from the Nix error output).Verification
nix/desktop.nix— Nix file, no Python tests to run.Closes #72095