fix: handle None request_overrides in _build_api_kwargs - #7210
Closed
leefbiant wants to merge 1 commit into
Closed
Conversation
3 tasks
Contributor
|
Thanks for the fix, @leefbiant! This is a valid bug report. However, the identical guard was already merged on the same day via PR #7350 (commit fast_mode=(self.request_overrides or {}).get("speed") == "fast",— exactly the change proposed here. Closing as implemented on main. This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
request_overridesisNone, calling.get("speed")raisesAttributeError. Guard with(self.request_overrides or {}).Fixes regression from #7037 (Anthropic Fast Mode support).