fix(windows): add missing encoding to livetest2 result write_text - #72097
Closed
mannnrachman wants to merge 1 commit into
Closed
fix(windows): add missing encoding to livetest2 result write_text#72097mannnrachman wants to merge 1 commit into
mannnrachman wants to merge 1 commit into
Conversation
a2c42be added explicit encodings to the livetest harness (PLW1514) but missed the per-scenario result write in _run_one, so check-windows-footguns.py --all now fails CI for every PR. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
19 tasks
19 tasks
Contributor
|
Thanks for identifying the remaining Windows encoding issue. This automated hermes-sweeper review found that current
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unbreaks the
check-windows-footguns.py --allCI gate, which currently fails for every PR.a2c42be (
fix(lint): explicit encoding on write_text in livetest harness (PLW1514)) added encodings to the livetest harness but missed the per-scenario result write in_run_one, leaving one barePath.write_text()onscripts/tool_search_livetest2.py:190. Since the CI job scans with--all, that single pre-existing miss now fails the gate for unrelated PRs (observed on #72094).Related Issue
Part of the #71014 / #37423
read_text/write_textencoding campaign.Type of Change
Changes Made
scripts/tool_search_livetest2.py:out_path.write_text(..., encoding="utf-8")— the one call a2c42be missed.How to Test
Validation Results
✗ 1 Windows footgun(s) found across 818 file(s) scanned.(scripts/tool_search_livetest2.py:190)✓ No Windows footguns found (818 file(s) scanned).Checklist
Code
fix(scope):,feat(scope):, etc.)Documentation & Housekeeping
cli-config.yaml.exampleN/ACONTRIBUTING.md/AGENTS.mdN/Ascripts/check-windows-footguns.py --allpassesScreenshots / Logs
🤖 Generated with Claude Code