fix(gateway): add .3gp to MEDIA_DELIVERY_EXTS (#71621) - #71971
Closed
JonthanaHanh wants to merge 1 commit into
Closed
fix(gateway): add .3gp to MEDIA_DELIVERY_EXTS (#71621)#71971JonthanaHanh wants to merge 1 commit into
JonthanaHanh wants to merge 1 commit into
Conversation
MEDIA_DELIVERY_EXTS was missing .3gp while every per-platform _VIDEO_EXTS set already included it. This caused MEDIA:/path/clip.3gp to be neither extracted for native video delivery nor stripped by the cleanup regex, leaking the tag as plain text in chat. Fixes NousResearch#71621
alt-glitch
added
type/bug
Contributor
|
Closing as duplicate — this fix landed via PR #72170, which cherry-picked the earlier and slightly wider submission of the same change (#71683 by @Linux2010, which also covered the .webm drift in send_message_tool and the Feishu adapter) with authorship preserved. Thanks for the contribution regardless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #71621.
MEDIA_DELIVERY_EXTSingateway/platforms/base.pyis the shared allowlist for media extraction andMEDIA:tag cleanup. It included.webmbut omitted.3gp, while every per-platform_VIDEO_EXTSset already included.3gp.Changes
gateway/platforms/base.py: Added.3gpto the video partition ofMEDIA_DELIVERY_EXTSImpact
Without this fix,
MEDIA:/path/to/clip.3gpwas:Testing
.3gpnow appears inMEDIA_DELIVERY_EXTS_VIDEO_EXTSin the same file already contained.3gp(line 5394)py_compilepasses